From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB09g-0006K4-DC for qemu-devel@nongnu.org; Sun, 27 Nov 2016 09:10:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB09f-0006sw-Kx for qemu-devel@nongnu.org; Sun, 27 Nov 2016 09:10:08 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:42546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB09f-0006ph-F7 for qemu-devel@nongnu.org; Sun, 27 Nov 2016 09:10:07 -0500 Date: Sun, 27 Nov 2016 15:10:04 +0100 From: Samuel Thibault Message-ID: <20161127141004.GL8854@var.home> References: <1480069886-11703-1-git-send-email-yuval.shaia@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480069886-11703-1-git-send-email-yuval.shaia@oracle.com> Subject: Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, jan.kiszka@siemens.com Hello, Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > -#ifndef _WIN32 > -#define min(x,y) ((x) < (y) ? (x) : (y)) > -#define max(x,y) ((x) > (y) ? (x) : (y)) > -#endif This has protection against _WIN32, I guess that was on purpose. Perhaps qemu should avoid risking a clash with OS-provided min/max macros, by renaming these to qemu_min/max? Samuel