From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43248)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1cB1Ny-0007p5-Nv
	for qemu-devel@nongnu.org; Sun, 27 Nov 2016 10:28:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1cB1Nu-0005k0-Mv
	for qemu-devel@nongnu.org; Sun, 27 Nov 2016 10:28:58 -0500
Received: from hera.aquilenet.fr ([141.255.128.1]:45522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1cB1Nu-0005jt-Gk
	for qemu-devel@nongnu.org; Sun, 27 Nov 2016 10:28:54 -0500
Date: Sun, 27 Nov 2016 16:28:51 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20161127152851.GA25452@var.home>
References: <20161123185258.771-1-dgilbert@redhat.com>
	<20161123185258.771-5-dgilbert@redhat.com>
	<20161127151346.GP8854@var.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161127151346.GP8854@var.home>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] slirp: VMStatify socket level
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com

Samuel Thibault, on Sun 27 Nov 2016 16:13:46 +0100, wrote:
> Dr. David Alan Gilbert (git), on Wed 23 Nov 2016 18:52:57 +0000, wrote:
> > +static const VMStateDescription vmstate_slirp_socket_addr = {
> > +    .name = "slirp-socket-addr",
> > +    .version_id = 4,
> > +    .fields = (VMStateField[]) {
> > +        VMSTATE_UINT16(ss.ss_family, union slirp_sockaddr),
> > +        VMSTATE_UINT32_TEST(sin.sin_addr.s_addr, union slirp_sockaddr,
> > +                            slirp_family_inet),
> > +        VMSTATE_UINT16_TEST(sin.sin_port, union slirp_sockaddr,
> > +                            slirp_family_inet),
> > +        VMSTATE_END_OF_LIST()
> > +    }
> > +};
> 
> How will we be able to add the IPv6 case here?

Reading again your previous post, it seemed it'd be in
slirp_family_inet, but I don't immediately see how.

Applying your patch for 2.9 would thus make porting the code to IPv6
more difficult than how it is now, so I'm quite reluctant :)

Could you perhaps simply add the IPv6 case in your patch series already?
It shouldn't be much work for you who actually know how the VMSTATE
machinery is supposed to work (I guess the amount of people who care
about slirp *and* know about VMSTATE is extremely small), and a proof of
concept for the portability to non-ipv4 addresse spaces.

Samuel