qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] cutils: Define min and max marcos
@ 2016-11-25 10:31 Yuval Shaia
  2016-11-25 15:26 ` Markus Armbruster
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Yuval Shaia @ 2016-11-25 10:31 UTC (permalink / raw)
  To: peter.maydell, qemu-devel, samuel.thibault, jan.kiszka; +Cc: yuval.shaia

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 disas/m68k.c          | 5 +----
 include/qemu/cutils.h | 3 +++
 slirp/slirp.h         | 6 +-----
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/disas/m68k.c b/disas/m68k.c
index 8e7c3f7..7794abc 100644
--- a/disas/m68k.c
+++ b/disas/m68k.c
@@ -2,6 +2,7 @@
    sourceware.org CVS.  Original file boundaries marked with **** */
 
 #include "qemu/osdep.h"
+#include "qemu/cutils.h"
 #include <math.h>
 
 #include "disas/bfd.h"
@@ -4698,10 +4699,6 @@ get_field (const unsigned char *data, enum floatformat_byteorders order,
   return result;
 }
 
-#ifndef min
-#define min(a, b) ((a) < (b) ? (a) : (b))
-#endif
-
 /* Convert from FMT to a double.
    FROM is the address of the extended float.
    Store the double in *TO.  */
diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h
index 3e4ea23..9bf0e37 100644
--- a/include/qemu/cutils.h
+++ b/include/qemu/cutils.h
@@ -180,4 +180,7 @@ bool buffer_is_zero(const void *buf, size_t len);
 int uleb128_encode_small(uint8_t *out, uint32_t n);
 int uleb128_decode_small(const uint8_t *in, uint32_t *n);
 
+#define min(x, y) ((x) < (y) ? (x) : (y))
+#define max(x, y) ((x) > (y) ? (x) : (y))
+
 #endif
diff --git a/slirp/slirp.h b/slirp/slirp.h
index a1f3139..3da8239 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -2,6 +2,7 @@
 #define SLIRP_H
 
 #include "qemu/host-utils.h"
+#include "qemu/cutils.h"
 #include "slirp_config.h"
 
 #ifdef _WIN32
@@ -292,9 +293,4 @@ int tcp_emu(struct socket *, struct mbuf *);
 int tcp_ctl(struct socket *);
 struct tcpcb *tcp_drop(struct tcpcb *tp, int err);
 
-#ifndef _WIN32
-#define min(x,y) ((x) < (y) ? (x) : (y))
-#define max(x,y) ((x) > (y) ? (x) : (y))
-#endif
-
 #endif
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-11-29  6:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-25 10:31 [Qemu-devel] [PATCH] cutils: Define min and max marcos Yuval Shaia
2016-11-25 15:26 ` Markus Armbruster
2016-11-27 14:10 ` Samuel Thibault
2016-11-27 22:18   ` Yuval Shaia
2016-11-27 22:20     ` Samuel Thibault
2016-11-27 22:49       ` Yuval Shaia
2016-11-29  6:43 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).