From: Fam Zheng <famz@redhat.com>
To: Yuval Shaia <yuval.shaia@oracle.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros
Date: Mon, 28 Nov 2016 15:15:40 +0800 [thread overview]
Message-ID: <20161128071540.GA27013@lemon.cpc> (raw)
In-Reply-To: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com>
On Fri, 11/25 23:19, Yuval Shaia wrote:
> diff --git a/slirp/tcpip.h b/slirp/tcpip.h
> index 7bdb971..71eb6a6 100644
> --- a/slirp/tcpip.h
> +++ b/slirp/tcpip.h
> @@ -30,6 +30,8 @@
> * tcpip.h,v 1.3 1994/08/21 05:27:40 paul Exp
> */
>
> +#include "qemu/osdep.h"
> +
It's a rule that sources in QEMU always include "osdep.h" first, so this is not
necessary. There is a comment on this in scripts/clean-includes:
...
# .h files will have redundant includes (including includes of osdep.h)
# removed.
...
Other headers that uses MAX() don't include it either.
> #ifndef TCPIP_H
> #define TCPIP_H
next prev parent reply other threads:[~2016-11-28 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:19 [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros Yuval Shaia
2016-11-28 7:15 ` Fam Zheng [this message]
2016-11-28 7:39 ` Markus Armbruster
2016-11-28 9:14 ` Yuval Shaia
2016-11-29 13:32 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128071540.GA27013@lemon.cpc \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).