From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBGAG-0001gj-4u for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:15:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBGAD-000434-0n for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:15:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBGAC-00042r-Qc for qemu-devel@nongnu.org; Mon, 28 Nov 2016 02:15:44 -0500 Date: Mon, 28 Nov 2016 15:15:40 +0800 From: Fam Zheng Message-ID: <20161128071540.GA27013@lemon.cpc> References: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com> Subject: Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com, armbru@redhat.com On Fri, 11/25 23:19, Yuval Shaia wrote: > diff --git a/slirp/tcpip.h b/slirp/tcpip.h > index 7bdb971..71eb6a6 100644 > --- a/slirp/tcpip.h > +++ b/slirp/tcpip.h > @@ -30,6 +30,8 @@ > * tcpip.h,v 1.3 1994/08/21 05:27:40 paul Exp > */ > > +#include "qemu/osdep.h" > + It's a rule that sources in QEMU always include "osdep.h" first, so this is not necessary. There is a comment on this in scripts/clean-includes: ... # .h files will have redundant includes (including includes of osdep.h) # removed. ... Other headers that uses MAX() don't include it either. > #ifndef TCPIP_H > #define TCPIP_H