qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yang Wei <w90p710@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, w90p710@gmail.com
Subject: [Qemu-devel] [PATCH] block/mirror: Fix passing wrong argument to trace_mirror_yield
Date: Mon, 28 Nov 2016 16:58:16 +0800	[thread overview]
Message-ID: <20161128085816.6161-1-w90p710@gmail.com> (raw)

mirror_yield is defined in block/trace-event, just like the following:
mirror_yield(void *s, int64_t cnt, int buf_free_count, int in_flight)
so we should exchange arguement 2 and 4 while invoking it.

Signed-off-by: Yang Wei <w90p710@gmail.com>
---
 block/mirror.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/mirror.c b/block/mirror.c
index 301ba92..2846a2e 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -577,7 +577,7 @@ static int coroutine_fn mirror_dirty_init(MirrorBlockJob *s)
             }
 
             if (s->in_flight >= MAX_IN_FLIGHT) {
-                trace_mirror_yield(s, s->in_flight, s->buf_free_count, -1);
+                trace_mirror_yield(s,  -1, s->buf_free_count, s->in_flight);
                 mirror_wait_for_io(s);
                 continue;
             }
@@ -730,7 +730,7 @@ static void coroutine_fn mirror_run(void *opaque)
             s->common.iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
             if (s->in_flight >= MAX_IN_FLIGHT || s->buf_free_count == 0 ||
                 (cnt == 0 && s->in_flight > 0)) {
-                trace_mirror_yield(s, s->in_flight, s->buf_free_count, cnt);
+                trace_mirror_yield(s, cnt, s->buf_free_count, s->in_flight);
                 mirror_wait_for_io(s);
                 continue;
             } else if (cnt != 0) {
-- 
2.10.2

             reply	other threads:[~2016-11-28  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  8:58 Yang Wei [this message]
2016-11-28 15:43 ` [Qemu-devel] [PATCH] block/mirror: Fix passing wrong argument to trace_mirror_yield Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128085816.6161-1-w90p710@gmail.com \
    --to=w90p710@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).