From: Yuval Shaia <yuval.shaia@oracle.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros
Date: Mon, 28 Nov 2016 11:14:43 +0200 [thread overview]
Message-ID: <20161128091442.GA22091@yuval-lap> (raw)
In-Reply-To: <878ts459zq.fsf@dusky.pond.sub.org>
On Mon, Nov 28, 2016 at 08:39:21AM +0100, Markus Armbruster wrote:
> The "{disas, slirp}: " prefix is unusual. Better: "disas, slirp: ".
> But I'd instead split the patch into the slirp part, where you really
> replace stuff, and the disas part, where you merely drop an unused macro
> definition.
Thanks,
Accepting your first suggestion as just now realized that actually this
macro is in use (disas/m68k.c lines 4732 and 4796).
(Can't explain how i missed that in v0)
next prev parent reply other threads:[~2016-11-28 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:19 [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros Yuval Shaia
2016-11-28 7:15 ` Fam Zheng
2016-11-28 7:39 ` Markus Armbruster
2016-11-28 9:14 ` Yuval Shaia [this message]
2016-11-29 13:32 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128091442.GA22091@yuval-lap \
--to=yuval.shaia@oracle.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).