From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBI1m-0005YD-Pr for qemu-devel@nongnu.org; Mon, 28 Nov 2016 04:15:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBI1f-0001sG-Bb for qemu-devel@nongnu.org; Mon, 28 Nov 2016 04:15:10 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:28335) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBI1f-0001rf-2M for qemu-devel@nongnu.org; Mon, 28 Nov 2016 04:15:03 -0500 Date: Mon, 28 Nov 2016 11:14:43 +0200 From: Yuval Shaia Message-ID: <20161128091442.GA22091@yuval-lap> References: <1480108791-16178-1-git-send-email-yuval.shaia@oracle.com> <878ts459zq.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878ts459zq.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com On Mon, Nov 28, 2016 at 08:39:21AM +0100, Markus Armbruster wrote: > The "{disas, slirp}: " prefix is unusual. Better: "disas, slirp: ". > But I'd instead split the patch into the slirp part, where you really > replace stuff, and the disas part, where you merely drop an unused macro > definition. Thanks, Accepting your first suggestion as just now realized that actually this macro is in use (disas/m68k.c lines 4732 and 4796). (Can't explain how i missed that in v0)