From: Amit Shah <amit.shah@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, quintela@redhat.com,
pavel.dovgaluk@ispras.ru
Subject: Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility
Date: Tue, 29 Nov 2016 11:24:53 +0530 [thread overview]
Message-ID: <20161129055453.GA2264@amit-lp.rh> (raw)
In-Reply-To: <20161128133201.16104-1-dgilbert@redhat.com>
On (Mon) 28 Nov 2016 [13:31:59], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Hi,
> 39c88f56 added VMState for pcspk but turned it on for
> all machine types, this breaks backwards compatibility
> to older machine types.
>
> If this is too late for 2.8 then I suggest we take the 1st
> of these two patches, which just makes it a property to flip
> for those of us who need it. Adding the 2nd patch after 2.8
> might cause problems for people using 2.8 with 2.7 machine
> type.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
We should take both for 2.8, thanks!
Amit
prev parent reply other threads:[~2016-11-29 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 13:31 [Qemu-devel] [PATCH 0/2] pcspk migration compatibility Dr. David Alan Gilbert (git)
2016-11-28 13:32 ` [Qemu-devel] [PATCH 1/2] migration/pcspk: Add a property to state if pcspk is migrated Dr. David Alan Gilbert (git)
2016-11-28 13:32 ` [Qemu-devel] [PATCH 2/2] migration/pcspk: Turn migration of pcspk off for 2.7 and older Dr. David Alan Gilbert (git)
2016-11-28 15:09 ` [Qemu-devel] [PATCH 0/2] pcspk migration compatibility Paolo Bonzini
2016-11-28 15:12 ` Dr. David Alan Gilbert
2016-11-29 5:54 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129055453.GA2264@amit-lp.rh \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).