From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBejb-0002st-Hj for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:29:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBejY-0002c0-So for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:29:55 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56775 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBejY-0002bp-MJ for qemu-devel@nongnu.org; Tue, 29 Nov 2016 04:29:52 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAT9SmU0129385 for ; Tue, 29 Nov 2016 04:29:51 -0500 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0b-001b2d01.pphosted.com with ESMTP id 27155e60te-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 29 Nov 2016 04:29:51 -0500 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Nov 2016 09:29:47 -0000 Date: Tue, 29 Nov 2016 10:29:35 +0100 From: Cornelia Huck In-Reply-To: <20161129092549.GC5152@stefanha-x1.localdomain> References: <1480334903-6672-1-git-send-email-arei.gonglei@huawei.com> <1480334903-6672-2-git-send-email-arei.gonglei@huawei.com> <20161128162055.GB11196@stefanha-x1.localdomain> <20161128185747-mutt-send-email-mst@kernel.org> <33183CC9F5247A488A2544077AF19020DA14A7A9@DGGEMA505-MBX.china.huawei.com> <20161129092549.GC5152@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161129102935.405892bd.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "Gonglei (Arei)" , "Michael S. Tsirkin" , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , Luonengjun , "Huangweidong (C)" , "Wubin (H)" , "xin.zeng@intel.com" , Claudio Fontana , "herbert@gondor.apana.org.au" , "pasic@linux.vnet.ibm.com" , "davem@davemloft.net" , "Zhoujian (jay, Euler)" , "Hanweidong (Randy)" , "arei.gonglei@hotmail.com" , "Xuquan (Quan Xu)" , longpeng , "salvatore.benedetto@intel.com" On Tue, 29 Nov 2016 09:25:49 +0000 Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 08:22:58AM +0000, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > index ad7250f..bc53cb8 100644 > > > > > > --- a/drivers/crypto/Makefile > > > > > > +++ b/drivers/crypto/Makefile > > > > > > @@ -32,3 +32,4 @@ obj-$(CONFIG_CRYPTO_DEV_VMX) += vmx/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_SUN4I_SS) += sunxi-ss/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_ROCKCHIP) += rockchip/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_CHELSIO) += chelsio/ > > > > > > +obj-$(CONFIG_CRYPTO_DEV_VIRTIO) += virtio/ > > > > > > diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig > > > > > > new file mode 100644 > > > > > > index 0000000..ceae88c > > > > > > --- /dev/null > > > > > > +++ b/drivers/crypto/virtio/Kconfig > > > > > > @@ -0,0 +1,10 @@ > > > > > > +config CRYPTO_DEV_VIRTIO > > > > > > + tristate "VirtIO crypto driver" > > > > > > + depends on VIRTIO > > > > > > + select CRYPTO_AEAD > > > > > > + select CRYPTO_AUTHENC > > > > > > + select CRYPTO_BLKCIPHER > > > > > > > > > > Inconsistent tab vs space whitespace usage. > > > > > > > > Will fix. > > > > > > > > > + default m > > > > > > + help > > > > > > + This driver provides support for virtio crypto device. If you > > > > > > + choose 'M' here, this module will be called virtio-crypto. > > > > > > > > > > All the other virtio drivers use underscore ('_') instead of hyphen > > > > > ('-'). > > > > > > > > Except virtio-rng. > > > > > > > > > I suggest calling it virtio_crypto for consistency. > > > > > > > > OK, I will change the Makefile to fix it. > > > > > > > I tried to do this, but I failed. Because virtio_crypto.ko > > consists of more than one source file which include tree files currently, > > and virtio_crypto.ko matchs the name of virtio_crypto.c. > > That's different with all other virtio drivers. > > Can you rename virtio_crypto.c to virtio_crypto_core.c? +1 I think that's the way to go.