From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBgtY-000305-HJ for qemu-devel@nongnu.org; Tue, 29 Nov 2016 06:48:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBgtX-00082A-8W for qemu-devel@nongnu.org; Tue, 29 Nov 2016 06:48:20 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 29 Nov 2016 12:47:02 +0100 Message-Id: <20161129114707.2975-6-pbonzini@redhat.com> In-Reply-To: <20161129114707.2975-1-pbonzini@redhat.com> References: <20161129114707.2975-1-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 05/10] aio: tweak walking in dispatch phase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Preparing for the following patch, use QLIST_FOREACH_SAFE and modify the placement of walking_handlers increment/decrement. Signed-off-by: Paolo Bonzini --- aio-posix.c | 27 +++++++++++++-------------- aio-win32.c | 26 ++++++++++++-------------- 2 files changed, 25 insertions(+), 28 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index e13b9ab..93a50ad 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -292,7 +292,7 @@ bool aio_pending(AioContext *ctx) bool aio_dispatch(AioContext *ctx) { - AioHandler *node; + AioHandler *node, *tmp; bool progress = false; /* @@ -308,12 +308,10 @@ bool aio_dispatch(AioContext *ctx) * We have to walk very carefully in case aio_set_fd_handler is * called while we're walking. */ - node = QLIST_FIRST(&ctx->aio_handlers); - while (node) { - AioHandler *tmp; - int revents; + ctx->walking_handlers++; - ctx->walking_handlers++; + QLIST_FOREACH_SAFE(node, &ctx->aio_handlers, node, tmp) { + int revents; revents = node->pfd.revents & node->pfd.events; node->pfd.revents = 0; @@ -337,17 +335,18 @@ bool aio_dispatch(AioContext *ctx) progress = true; } - tmp = node; - node = QLIST_NEXT(node, node); - - ctx->walking_handlers--; - - if (!ctx->walking_handlers && tmp->deleted) { - QLIST_REMOVE(tmp, node); - g_free(tmp); + if (node->deleted) { + ctx->walking_handlers--; + if (!ctx->walking_handlers) { + QLIST_REMOVE(node, node); + g_free(node); + } + ctx->walking_handlers++; } } + ctx->walking_handlers--; + /* Run our timers */ progress |= timerlistgroup_run_timers(&ctx->tlg); diff --git a/aio-win32.c b/aio-win32.c index c8c249e..f27b56b 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -209,20 +209,18 @@ bool aio_pending(AioContext *ctx) static bool aio_dispatch_handlers(AioContext *ctx, HANDLE event) { - AioHandler *node; + AioHandler *node, *tmp; bool progress = false; + ctx->walking_handlers++; + /* * We have to walk very carefully in case aio_set_fd_handler is * called while we're walking. */ - node = QLIST_FIRST(&ctx->aio_handlers); - while (node) { - AioHandler *tmp; + QLIST_FOREACH_SAFE(node, &ctx->aio_handlers, node, tmp) { int revents = node->pfd.revents; - ctx->walking_handlers++; - if (!node->deleted && (revents || event_notifier_get_handle(node->e) == event) && node->io_notify) { @@ -257,17 +255,17 @@ static bool aio_dispatch_handlers(AioContext *ctx, HANDLE event) } } - tmp = node; - node = QLIST_NEXT(node, node); - - ctx->walking_handlers--; - - if (!ctx->walking_handlers && tmp->deleted) { - QLIST_REMOVE(tmp, node); - g_free(tmp); + if (node->deleted) { + ctx->walking_handlers--; + if (!ctx->walking_handlers) { + QLIST_REMOVE(node, node); + g_free(node); + } + ctx->walking_handlers++; } } + ctx->walking_handlers--; return progress; } -- 2.9.3