From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBm1f-0006YF-L9 for qemu-devel@nongnu.org; Tue, 29 Nov 2016 12:17:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBm1c-0001Pg-DN for qemu-devel@nongnu.org; Tue, 29 Nov 2016 12:17:03 -0500 Date: Tue, 29 Nov 2016 17:16:56 +0000 From: Stefan Hajnoczi Message-ID: <20161129171656.GA7838@stefanha-x1.localdomain> References: <20161129153720.29747-1-pbonzini@redhat.com> <20161129162229.GA26498@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-stable@nongnu.org --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 29, 2016 at 05:57:04PM +0100, Paolo Bonzini wrote: >=20 >=20 > On 29/11/2016 17:22, Stefan Hajnoczi wrote: > > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: > >> Building qemu fails in distributions where gcc enables PIE by default > >> (e.g. Debian unstable) with: > >> > >> /usr/bin/ld: -r and -pie may not be used together > >> > >> You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the = linker > >> when PIE is enabled and a relocatable object is passed. However, clang > >> does not know about -r, so try -Wl,-r first. > >> > >> Reported-by: Adrian Bunk > >> Cc: qemu-stable@nongnu.org > >> Signed-off-by: Paolo Bonzini > >> --- > >> configure | 10 ++++++++-- > >> rules.mak | 2 +- > >> 2 files changed, 9 insertions(+), 3 deletions(-) > >=20 > > Thanks, applied to my staging tree: > > https://github.com/stefanha/qemu/commits/staging >=20 > Okay, then I'll send my pull request without this one. FWIW I applied the pull request with the broken -r fix. Then I applied this patch on top (and added a note to the commit description explaining this was a refinement). I've also merged your newest pull request for -rc2. Hopefully this got us into a more or less the state you expected? :) Stefan --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYPbgIAAoJEJykq7OBq3PIn64H/37q1xlCsg0m3G6984mdp2r5 FBM9hQKFxcYE7Wu/cqdtP8x/ZWzcLCsgMMu0g1xzX5AuLBewU7/tsZ9XVYbDTO55 nByCsE/klwmpFAI4xBKTbk71tTwqU6XgUsZl/U7xHTZ1CRg+aA3mSTqV9RQynHxO Qda5qLywBKs0x6te0mT0qGztdGENRBy0CyxmeBEDKWJiq5O9Md+EnLX1zcjXRRLh WTmrIUKSQp1VKHjDrJ2VGm7icYD0PZVs5w3FjZyLXj2AwG7kMOQ/DLTSIuyMQsrf 6Y/N2bK2A2CTeuAovqwdsrQ+rKjgmLrvVbvPso4JceuCqcWfMoXtV94rQvriD94= =h21y -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--