From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54579)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1cC3yf-0006eP-Lf
	for qemu-devel@nongnu.org; Wed, 30 Nov 2016 07:27:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1cC3yc-0002RR-AT
	for qemu-devel@nongnu.org; Wed, 30 Nov 2016 07:27:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46356)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <famz@redhat.com>) id 1cC3yc-0002Qx-4a
	for qemu-devel@nongnu.org; Wed, 30 Nov 2016 07:27:06 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 4FE0983F3F
	for <qemu-devel@nongnu.org>; Wed, 30 Nov 2016 12:27:05 +0000 (UTC)
Date: Wed, 30 Nov 2016 20:27:03 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20161130122703.GD27283@lemon>
References: <9151aa4b-44ed-ee0f-4dac-581931b3e899@redhat.com>
	<1480503358.20354.23.camel@redhat.com>
	<0a6692f7-d2d3-2902-d5f0-77035c90a6cb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0a6692f7-d2d3-2902-d5f0-77035c90a6cb@redhat.com>
Subject: Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu devel list <qemu-devel@nongnu.org>

On Wed, 11/30 13:03, Laszlo Ersek wrote:
> On 11/30/16 11:55, Gerd Hoffmann wrote:
> > On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
> >> Recent git releases support the diff.orderFile permanent setting.
> > 
> > Cool.
> > 
> >> configure
> >> *Makefile*
> >> *.json
> >> *.txt
> >> *.h
> >> *.c
> > 
> > I'd put *.txt to the head so doc updates come first.
> 
> Good idea, yes.
> 
> > Otherwise the order looks good to me.
> > 
> > Want sent a patch?
> 
> What file for? :)

This is a nice feature, thanks!

Does it make sense to have a .gitpublish file (for Stefan's git-publish script)
in QEMU.git? That way we can add a new profile option to git-publish and let it
build the command line accordingly. This is going to be helpful for those who
already use git-publish.

> 
> I've considered modifying
> <http://wiki.qemu.org/Contribute/SubmitAPatch>, but that article is
> humongous already.

And this sounds good too.

Fam

> 
> Nonetheless, section "Make code motion patches easy to review" mentions
> some diff.* settings, so I guess a new section after it ("Format
> declarative and abstract changes near the top") would be appropriate, if
> there's no disagreement.
> 
> > Can this be automatically enabled per repo, like .gitignore, so it works
> > without everybody tweaking its local git config?
> 
> Not to my understanding.
> 
> Thanks!
> Laszlo
> 
>