From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40874)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1cC4Nq-00070J-7b
	for qemu-devel@nongnu.org; Wed, 30 Nov 2016 07:53:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1cC4Nm-0003Nc-5A
	for qemu-devel@nongnu.org; Wed, 30 Nov 2016 07:53:10 -0500
Date: Wed, 30 Nov 2016 12:53:02 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20161130125302.GD2497@stefanha-x1.localdomain>
References: <20161129114707.2975-1-pbonzini@redhat.com>
	<20161129114707.2975-2-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="7DO5AaGCk89r4vaK"
Content-Disposition: inline
In-Reply-To: <20161129114707.2975-2-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] aio: rename bh_lock to list_lock
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org


--7DO5AaGCk89r4vaK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 29, 2016 at 12:46:58PM +0100, Paolo Bonzini wrote:
> diff --git a/include/block/aio.h b/include/block/aio.h
> index c7ae27c..eee3139 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -90,7 +90,7 @@ struct AioContext {
>      uint32_t notify_me;
> =20
>      /* lock to protect between bh's adders and deleter */
> -    QemuMutex bh_lock;
> +    QemuMutex list_lock;

Please update the comment.  Looks good otherwise:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--7DO5AaGCk89r4vaK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJYPsuuAAoJEJykq7OBq3PIIlgH/Ayk9uChkw+4QW4ctvWVWyWA
sPn1fAEH8pnH5tjnvbXviCZzuIsbeL3uZJo+vA7fzuq3iRWSaKOiOF9N74l/BQwD
mfIYyUc84meKnv6ZDqlJ6vJWCcvtl+95FHQs0+9oe5AEe1LJortSX1kSfR+PZz/K
FxxwUmzoPDPeA44J9/6ZBki6glxJdMHzE19Mz7Iuvq1i8Tav9JFWgFLDcJTNA9Ra
vvNwv5DLRunhJwfwCb8fOXofPoVsKh5aMCHxrJi430rYw3lV2SvQf4B1ZU9hzCTG
/m5NKIP0KJXUshDSjw68LNZEHCXbVRNjvaE6sGeFavy8FlGoBwR20y0BrlWFIgI=
=Ioq+
-----END PGP SIGNATURE-----

--7DO5AaGCk89r4vaK--