From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCNll-0007SG-KY for qemu-devel@nongnu.org; Thu, 01 Dec 2016 04:35:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCNli-0005Vd-VR for qemu-devel@nongnu.org; Thu, 01 Dec 2016 04:35:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35076) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cCNli-0005Ux-QY for qemu-devel@nongnu.org; Thu, 01 Dec 2016 04:35:06 -0500 Date: Thu, 1 Dec 2016 09:35:00 +0000 From: "Daniel P. Berrange" Message-ID: <20161201093500.GC9191@redhat.com> Reply-To: "Daniel P. Berrange" References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] GTK UI keycodes broken under Wayland List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Stefan Hajnoczi , qemu-devel , Gerd Hoffmann , sm8ax1@vfemail.net On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote: > On 01.12.2016 08:24, Stefan Hajnoczi wrote: > > I recently upgraded to Fedora 25 which runs Wayland by default. > > > > The GTK UI is now sending unknown keycodes to the guests. Although > > alphanumeric keys work, the cursor keys are broken. > > > > There is X11-specific code for keycode mapping in ui/gtk.c. Perhaps > > something is needed to make that work under Wayland? > > There is certainly something missing for Wayland. Somebody already > reported this issue here and posted a "quick and dirty" patch: > > https://bugs.launchpad.net/qemu/+bug/1578192 That patch doesn't seem to apply for me and does more than is needed. I've just sent a simpler patch that ought to fix it, though I've not personally tested it, so would appreciate feedback from Stefan that his test VM keyboard works now. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|