Re: [Qemu-devel] a suggestion to place *.c hunks last in patches

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]

On Wed, Nov 30, 2016 at 03:48:01PM -0500, John Snow wrote:
> On 11/30/2016 07:03 AM, Laszlo Ersek wrote:
> > On 11/30/16 11:55, Gerd Hoffmann wrote:
> >> On Mi, 2016-11-30 at 11:08 +0100, Laszlo Ersek wrote:
> >>> Recent git releases support the diff.orderFile permanent setting.
> >>
> >> Cool.
> >>
> >>> configure
> >>> *Makefile*
> >>> *.json
> >>> *.txt
> >>> *.h
> >>> *.c
> >>
> >> I'd put *.txt to the head so doc updates come first.
> > 
> > Good idea, yes.
> > 
> >> Otherwise the order looks good to me.
> >>
> >> Want sent a patch?
> > 
> > What file for? :)
> > 
> > I've considered modifying
> > <http://wiki.qemu.org/Contribute/SubmitAPatch>, but that article is
> > humongous already.
> > 
> 
> <OFFTOPIC>
> 
> I am itching to split this article up.
> 
> It was a giant monolith when I found it, so I split it up into "phases"
> and added a TOC, but it's still too unapproachable.
> 
> I'm thinking _two_ articles:
> 
> (1) A quick and dirty checklist that people can reference for their
> first submissions to make sure they are in the correct universe when
> submitting a patch, written expressly to be easy to digest without being
> overwhelming, and

Sounds good.

Another option for making the first time contribution process easier is
to automate as many of the rules as possible.  Can some of it be
implemented in checkpatch.pl?  Are there git-hooks we should supply?

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]