From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cClkp-0006hg-2D for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:11:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cClkk-0004Gy-3G for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:11:47 -0500 Received: from mail-wj0-x244.google.com ([2a00:1450:400c:c01::244]:34107) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cClkj-0004GY-TM for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:11:42 -0500 Received: by mail-wj0-x244.google.com with SMTP id xy5so29789256wjc.1 for ; Fri, 02 Dec 2016 03:11:41 -0800 (PST) Date: Fri, 2 Dec 2016 11:11:38 +0000 From: Stefan Hajnoczi Message-ID: <20161202111138.GA16147@stefanha-x1.localdomain> References: <20161201192652.9509-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20161201192652.9509-1-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, Karl Rister , Fam Zheng , Paolo Bonzini --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 01, 2016 at 07:26:39PM +0000, Stefan Hajnoczi wrote: > v4: > * Added poll time self-tuning algorithm [Christian and Paolo] > * Try a single iteration of polling to avoid non-blocking ppoll(2)/epoll= _wait(2) [Paolo] > * Reordered patches to make performance analysis easier - see below >=20 > v3: > * Avoid ppoll(2)/epoll_wait(2) if polling succeeded [Paolo] > * Disable guest->host virtqueue notification during polling [Christian] > * Rebased on top of my virtio-blk/scsi virtqueue notification disable pa= tches Karl Rister found a performance regression between v2 -> v3. There was a bug in the poll_disable_cnt code in aio_set_fd_handler() which meant that polling was disabled unnecessarily. This has been fixed in v4 and I suspect it was the cause for the regression. Stefan --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYQVbqAAoJEJykq7OBq3PIetUH+QEgz+helJUyWXXTaKGVV4ga NMVnLptbRzBZMMi5lDX0hFCfEfp5bi/LseJyw9zHkK/OAXflVtIMSrU3mE1oIiio a9tGbAvXcCN/wlSM5g2sKiuslF9jSJmJN3F0WVSeq5czgN9gMYVrisCvo6p1Jbqo Pq0r7gRYMjSdlfrhTEdtcB13FPN5+u/UNicjNkpH+QMdGvMBBBq7qjrjqfOL1fYT 5Zh1cjOce7HvtFTF57s1eEbYD4QfZiD04sYxKpKhADM7UpEuvCRKpmcQY/B7OMLY I8KCAKXCkxzB6qd1RQv7KCtTXVZ1HsVCgn9HzoaVz8r73c4nNzyp26awvf67wew= =FKtW -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--