[Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

[Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

[Yaowei Bai]

It's timer to expire, not clock.

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
 include/qemu/timer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 309f3d0..c89ed2a 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -140,7 +140,7 @@ bool qemu_clock_has_timers(QEMUClockType type);
  * @type: the clock type
  *
  * Determines whether a clock's default timer list
- * has an expired clock.
+ * has an expired timer.
  *
  * Returns: true if the clock's default timer list has
  * an expired timer
-- 
1.8.3.1

[Qemu-devel] [PATCH 2/3] main-loop: update comment for qemu_mutex_lock/unlock_iothread

[Yaowei Bai]

Commit 49cf57281b7 (vl: delay thread initialization after daemonization)
makes the global mutex is taken after daemonization instead before
daemonization by qemu_init_main_loop().

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
 include/qemu/main-loop.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h
index 470f600..a9d4f23 100644
--- a/include/qemu/main-loop.h
+++ b/include/qemu/main-loop.h
@@ -238,7 +238,7 @@ bool qemu_mutex_iothread_locked(void);
  * qemu_mutex_lock_iothread: Lock the main loop mutex.
  *
  * This function locks the main loop mutex.  The mutex is taken by
- * qemu_init_main_loop and always taken except while waiting on
+ * main() in vl.c and always taken except while waiting on
  * external events (such as with select).  The mutex should be taken
  * by threads other than the main loop thread when calling
  * qemu_bh_new(), qemu_set_fd_handler() and basically all other
@@ -253,7 +253,7 @@ void qemu_mutex_lock_iothread(void);
  * qemu_mutex_unlock_iothread: Unlock the main loop mutex.
  *
  * This function unlocks the main loop mutex.  The mutex is taken by
- * qemu_init_main_loop and always taken except while waiting on
+ * main() in vl.c and always taken except while waiting on
  * external events (such as with select).  The mutex should be unlocked
  * as soon as possible by threads other than the main loop thread,
  * because it prevents the main loop from processing callbacks,
-- 
1.8.3.1

[Qemu-devel] [PATCH 3/3] block: drop remaining legacy aio functions in comment

[Yaowei Bai]

Commit 87f68d318222563822b5c6b28192215fc4b4e441 (block: drop aio
functions that operate on the main AioContext) drops qemu_aio_wait
function references mostly while leaves these behind, clean up them.

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
 include/block/aio.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/block/aio.h b/include/block/aio.h
index 9583c9e..c1c57bb 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -193,8 +193,8 @@ QEMUBH *aio_bh_new(AioContext *ctx, QEMUBHFunc *cb, void *opaque);
  * aio_notify: Force processing of pending events.
  *
  * Similar to signaling a condition variable, aio_notify forces
- * aio_wait to exit, so that the next call will re-examine pending events.
- * The caller of aio_notify will usually call aio_wait again very soon,
+ * aio_poll to exit, so that the next call will re-examine pending events.
+ * The caller of aio_notify will usually call aio_poll again very soon,
  * or go through another iteration of the GLib main loop.  Hence, aio_notify
  * also has the side effect of recalculating the sets of file descriptors
  * that the main loop waits for.
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote:
> It's timer to expire, not clock.
> 
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> ---
>  include/qemu/timer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

For the whole series:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

PS: I suggest sending a cover letter "[PATCH 0/3]" in the future.  This
makes it easy for reviewers to indicate they have reviewed the whole
series.  Without a cover letter it's ambiguous whether my single
Reviewed-by: applies to just this patch or to the whole series - and
patch management tools will probably get it wrong too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

[Paolo Bonzini]

On 01/12/2016 14:50, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote:
>> It's timer to expire, not clock.
>>
>> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
>> ---
>>  include/qemu/timer.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> For the whole series:
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> PS: I suggest sending a cover letter "[PATCH 0/3]" in the future.  This
> makes it easy for reviewers to indicate they have reviewed the whole
> series.  Without a cover letter it's ambiguous whether my single
> Reviewed-by: applies to just this patch or to the whole series - and
> patch management tools will probably get it wrong too.
> 

I've queued the series for QEMU 2.9.  This kind of patch can probably be
sent to qemu-trivial@nongnu.org, which will simplify their inclusion.

Of course, this is not meant to diminish your contribution!  "Trivial"
patches are important and good comments will also help the next person
studying QEMU's source code.

Thanks,

Paolo

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

[Yaowei Bai]

On Thu, Dec 01, 2016 at 04:23:17PM +0100, Paolo Bonzini wrote:
> 
> 
> On 01/12/2016 14:50, Stefan Hajnoczi wrote:
> > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote:
> >> It's timer to expire, not clock.
> >>
> >> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> >> ---
> >>  include/qemu/timer.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > For the whole series:
> > 
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > PS: I suggest sending a cover letter "[PATCH 0/3]" in the future.  This
> > makes it easy for reviewers to indicate they have reviewed the whole
> > series.  Without a cover letter it's ambiguous whether my single
> > Reviewed-by: applies to just this patch or to the whole series - and
> > patch management tools will probably get it wrong too.
> > 
> 
> I've queued the series for QEMU 2.9.  This kind of patch can probably be
> sent to qemu-trivial@nongnu.org, which will simplify their inclusion.
> 
> Of course, this is not meant to diminish your contribution!  "Trivial"
> patches are important and good comments will also help the next person
> studying QEMU's source code.

Got it from both of you, will correct it in the future, thanks.

> 
> Thanks,
> 
> Paolo