From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDjs0-0005JW-SC for qemu-devel@nongnu.org; Sun, 04 Dec 2016 22:23:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDjrw-0008M4-Kw for qemu-devel@nongnu.org; Sun, 04 Dec 2016 22:23:12 -0500 Date: Mon, 5 Dec 2016 14:14:55 +1100 From: David Gibson Message-ID: <20161205031455.GD12426@umbus.fritz.box> References: <1480741206-32737-1-git-send-email-joserz@linux.vnet.ibm.com> <1480741206-32737-5-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VMt1DrMGOVs3KQwf" Content-Disposition: inline In-Reply-To: <1480741206-32737-5-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 4/7] target-ppc: Implement bcdus. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --VMt1DrMGOVs3KQwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 03, 2016 at 03:00:03AM -0200, Jose Ricardo Ziviani wrote: > bcdus.: Decimal unsigned shift. This instruction works like bcds. but > considers only unsigned BCDs (no sign in least meaning 4 bits). >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 43 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 3 +++ > target-ppc/translate/vmx-ops.inc.c | 2 +- > 4 files changed, 48 insertions(+), 1 deletion(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 471a1da..386ea67 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -393,6 +393,7 @@ DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > DEF_HELPER_4(bcdcpsgn, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdsetsgn, i32, avr, avr, i32) > DEF_HELPER_4(bcds, i32, avr, avr, avr, i32) > +DEF_HELPER_4(bcdus, i32, avr, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index b25c020..4b5eea1 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -3081,6 +3081,49 @@ uint32_t helper_bcds(ppc_avr_t *r, ppc_avr_t *a, p= pc_avr_t *b, uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdus(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint32_t= ps) > +{ > + int cr; > + int i; > + int invalid =3D 0; > + bool ox_flag =3D false; > + ppc_avr_t ret =3D *b; > + > +#if defined(HOST_WORDS_BIGENDIAN) > + int upper =3D ARRAY_SIZE(a->s32) - 1; > +#else > + int upper =3D 0; > +#endif Retrieving the shift in terms of s32 elements, seems very odd when the architecture defines the shift argument in terms of byte elements of the vector. > + > + for (i =3D 0; i < 32; i++) { > + bcd_get_digit(b, i, &invalid); > + > + if (unlikely(invalid)) { > + return CRF_SO; > + } > + } > + > + if (a->s32[upper] >=3D 32) { > + ox_flag =3D true; > + ret.u64[LO_IDX] =3D ret.u64[HI_IDX] =3D 0; > + } else if (a->s32[upper] <=3D -32) { > + ret.u64[LO_IDX] =3D ret.u64[HI_IDX] =3D 0; > + } else if (a->s32[upper] > 0) { > + i =3D a->s32[upper] & 31; > + ulshift(&ret.u64[LO_IDX], &ret.u64[HI_IDX], i * 4, &ox_flag); > + } else { > + i =3D (-a->s32[upper]) & 31; > + urshift(&ret.u64[LO_IDX], &ret.u64[HI_IDX], i * 4); > + } > + > + cr =3D bcd_cmp_zero(r); > + if (unlikely(ox_flag)) { > + cr |=3D CRF_SO; > + } > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 84ebb7e..fc54881 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -1017,6 +1017,7 @@ GEN_BCD2(bcdctsq) > GEN_BCD2(bcdsetsgn) > GEN_BCD(bcdcpsgn); > GEN_BCD(bcds); > +GEN_BCD(bcdus); > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -1093,6 +1094,8 @@ GEN_VXFORM_DUAL(vaddshs, PPC_ALTIVEC, PPC_NONE, \ > bcdcpsgn, PPC_NONE, PPC2_ISA300) > GEN_VXFORM_DUAL(vsubudm, PPC2_ALTIVEC_207, PPC_NONE, \ > bcds, PPC_NONE, PPC2_ISA300) > +GEN_VXFORM_DUAL(vsubuwm, PPC_ALTIVEC, PPC_NONE, \ > + bcdus, PPC_NONE, PPC2_ISA300) > =20 > static void gen_vsbox(DisasContext *ctx) > { > diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vm= x-ops.inc.c > index 7b4b009..cdd3abe 100644 > --- a/target-ppc/translate/vmx-ops.inc.c > +++ b/target-ppc/translate/vmx-ops.inc.c > @@ -61,7 +61,7 @@ GEN_VXFORM(vadduwm, 0, 2), > GEN_VXFORM_207(vaddudm, 0, 3), > GEN_VXFORM_DUAL(vsububm, bcdadd, 0, 16, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM_DUAL(vsubuhm, bcdsub, 0, 17, PPC_ALTIVEC, PPC_NONE), > -GEN_VXFORM(vsubuwm, 0, 18), > +GEN_VXFORM_DUAL(vsubuwm, bcdus, 0, 18, PPC_ALTIVEC, PPC2_ISA300), > GEN_VXFORM_DUAL(vsubudm, bcds, 0, 19, PPC2_ALTIVEC_207, PPC2_ISA300), > GEN_VXFORM_300(bcds, 0, 27), > GEN_VXFORM(vmaxub, 1, 0), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --VMt1DrMGOVs3KQwf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYRNuvAAoJEGw4ysog2bOSZ+kP+wftWsK8qO+A5JJMeXvl0fhk 2ACiIDPq3FJtSPxTKMkSf/jTQZi1Ciy8OZxjjt2Sae4GNmzAS+c3iPx1IK1m/PCR kDMRq6q14fILUE59IlY3prqSzvrxe2ajScYhQ3acKFvvB0K/2fI0tMRpOsYW1ygH 0Rr+tOPx67QYC3sRrekEAU2G/DIFMkHBNIE5DJhki6w8vtX0qnhbDQe4+NoGTEWR a9FiRuRWOYNjI9cg90+MTJAx9+obZP0lANqkzCa8HK4pgRe8HrAFID4MZmcwRgOA XR8Rl81w7oEfInCc3mA3Z83KkfTIny/X1jaZKYEc1/3KeFNqL0LgtX/FrkcraR5U L2Gbcw974orQAC5N/ZE7Q4VvrL9BP/2vIuir79/P8nNe94lhZ2EivzZu2bT7jm93 MCl4Oac9phSbWcGuj6v6uq7nDhleGtabYc5u9suVQMbigvajnArmL7ln7LA41QRw 0q6QXBwxXz28H1XTIGCFxWcibS6aq/cJjxK4RGvTmtNw/Zlf0Gdq/PFR4RVMvof5 GHZQDBi7ZWqF9dRjopuLXncPHzwoR6pOZCJSASEAIlK4ccntvMp89Ba2P3bLY4OV o/JLDLcEFQJ8R8LvyRIlmIUUp4Za/34lL0O6QXUGPW/6Uge0JUIVoZZfax8EHyzM F/Qes6W+jqxJex2PGJck =EHe8 -----END PGP SIGNATURE----- --VMt1DrMGOVs3KQwf--