From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDpWz-00069P-S7 for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:25:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDpWw-0006nr-6b for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:25:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDpWw-0006nf-0y for qemu-devel@nongnu.org; Mon, 05 Dec 2016 04:25:50 -0500 Date: Mon, 5 Dec 2016 09:25:43 +0000 From: "Daniel P. Berrange" Message-ID: <20161205092543.GC2498@redhat.com> Reply-To: "Daniel P. Berrange" References: <1480928380-161760-1-git-send-email-longpeng2@huawei.com> <1480928380-161760-3-git-send-email-longpeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1480928380-161760-3-git-send-email-longpeng2@huawei.com> Subject: Re: [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Longpeng(Mike)" Cc: eblake@redhat.com, armbru@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, wu.wubin@huawei.com, jianjay.zhou@huawei.com On Mon, Dec 05, 2016 at 04:59:39PM +0800, Longpeng(Mike) wrote: > The cryptodev use DES-RFB for ecb(des) currently, we should use > standard DES for cryptodev instead. > > Signed-off-by: Longpeng(Mike) > --- > backends/cryptodev-builtin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c > index ecad565..f1b5b1b 100644 > --- a/backends/cryptodev-builtin.c > +++ b/backends/cryptodev-builtin.c > @@ -207,7 +207,7 @@ static int cryptodev_builtin_create_cipher_session( > break; > case VIRTIO_CRYPTO_CIPHER_DES_ECB: > mode = QCRYPTO_CIPHER_MODE_ECB; > - algo = QCRYPTO_CIPHER_ALG_DES_RFB; > + algo = QCRYPTO_CIPHER_ALG_DES; > break; > default: > error_setg(errp, "Unsupported cipher alg :%u", This will need updating due to my suggestion to change the enum name, but regardless this fix is clearly needed - we don't want cryptodev using the VNC custom bit-reversed single-DES Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|