From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] qapi: Document introduction of gluster's 'debug' option
Date: Tue, 6 Dec 2016 20:22:08 +0000 [thread overview]
Message-ID: <20161206202208.GF2521@stefanha-x1.localdomain> (raw)
In-Reply-To: <20161206182020.25736-1-eblake@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Tue, Dec 06, 2016 at 12:20:20PM -0600, Eric Blake wrote:
> We intentionally renamed 'debug-level' to 'debug' in the QMP
> schema for 'blockdev-add' related to gluster, in order to
> match the command line (commit 1a417e46). However, since
> 'debug-level' was visible in 2.7, that means that we should
> document that 'debug' was not available until 2.8.
>
> The change was intentional because 'blockdev-add' itself
> underwent incompatible changes (such as commit 0153d2f) for
> the same release; our intent is that after 2.8, these
> interfaces will now be stable. [In hindsight, we should have
> used the name x-blockdev-add when we first introduced it]
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/block-core.json | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-12-06 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 18:20 [Qemu-devel] [PATCH for-2.8] qapi: Document introduction of gluster's 'debug' option Eric Blake
2016-12-06 20:22 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206202208.GF2521@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).