From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration
Date: Wed, 7 Dec 2016 18:03:39 +0800 [thread overview]
Message-ID: <20161207100339.GB2286@lemon> (raw)
In-Reply-To: <20161207094832.GA4773@noname.str.redhat.com>
On Wed, 12/07 10:48, Kevin Wolf wrote:
> > If so I think there is no race to worry about, mirror-filter should go
> > away only after a QMP command.
>
> Currently, a mirror job goes away whenever it is done. This is not
> directly tied to a QMP command.
Ah right, block-job-complete is only "start to complete" and the job goes away
at some later point. I thought this is "the" QMP command but it is not.
>
> Of course, in the new job API we want an explicit job-delete, so in
> that case it wouldn't happen, but we need to keep the old case for
> compatibility.
Another possibility is to add a placeholder node in the right location first
then fill in the actual throttling node once created. QMP owns the placeholder
node so it won't suddenly vanish when mirror job goes away.
Fam
next prev parent reply other threads:[~2016-12-07 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 12:03 [Qemu-devel] Meeting notes on -blockdev, dynamic backend reconfiguration Markus Armbruster
2016-12-06 11:03 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-12-07 2:55 ` [Qemu-devel] " Fam Zheng
2016-12-07 9:48 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-12-07 10:03 ` Fam Zheng [this message]
2016-12-08 12:46 ` Markus Armbruster
2016-12-08 13:47 ` Fam Zheng
2016-12-12 13:58 ` Markus Armbruster
2016-12-12 14:43 ` Fam Zheng
2016-12-12 18:23 ` Markus Armbruster
2016-12-13 6:51 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207100339.GB2286@lemon \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).