From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, mreitz@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic
Date: Wed, 7 Dec 2016 17:17:36 +0100 [thread overview]
Message-ID: <20161207161736.GI4773@noname.str.redhat.com> (raw)
In-Reply-To: <20161202192223.15153-4-eblake@redhat.com>
Am 02.12.2016 um 20:22 hat Eric Blake geschrieben:
> Rather than store into a local variable, the copy to the struct
> if the value is valid, then reporting errors otherwise, it is
> simpler to just store into the struct and report errors if the
> value is invalid. This however requires that the struct store
> a 64-bit number, rather than a narrower type.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2016-12-07 16:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:22 [Qemu-devel] [PATCH v3 0/5] add blkdebug tests Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 1/5] blkdebug: Sanity check block layer guarantees Eric Blake
2016-12-06 21:26 ` Max Reitz
2016-12-07 16:17 ` Kevin Wolf
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support Eric Blake
2016-12-06 22:00 ` Max Reitz
2016-12-06 22:12 ` Eric Blake
2016-12-06 22:14 ` Max Reitz
2016-12-06 22:18 ` Eric Blake
2016-12-06 22:23 ` Max Reitz
2016-12-06 22:36 ` Eric Blake
2016-12-07 13:55 ` Kevin Wolf
2016-12-07 15:15 ` Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic Eric Blake
2016-12-06 22:10 ` Max Reitz
2016-12-06 22:15 ` Eric Blake
2016-12-07 16:17 ` Kevin Wolf [this message]
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries Eric Blake
2016-12-06 22:31 ` Max Reitz
2016-12-07 14:35 ` Kevin Wolf
2016-12-07 15:11 ` Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes Eric Blake
2016-12-06 22:33 ` Max Reitz
2016-12-07 16:16 ` Kevin Wolf
2016-12-07 16:34 ` Eric Blake
2016-12-20 16:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207161736.GI4773@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).