From: Sam Ravnborg <sam@ravnborg.org>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: kbuild test robot <lkp@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kbuild-all@01.org" <kbuild-all@01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Luonengjun <luonengjun@huawei.com>,
"mst@redhat.com" <mst@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"Wubin (H)" <wu.wubin@huawei.com>,
"xin.zeng@intel.com" <xin.zeng@intel.com>,
Claudio Fontana <Claudio.Fontana@huawei.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"pasic@linux.vnet.ibm.com" <pasic@linux.vnet.ibm.com>,
"Zhoujian (jay, Euler)" <jianjay.zhou@huawei.com>,
"Hanweidong (Randy)" <hanweidong@huawei.com>,
"arei.gonglei@hotmail.com" <arei.gonglei@hotmail.com>,
"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"Xuquan (Quan Xu)" <xuquan8@huawei.com>,
longpeng <longpeng2@huawei.com>,
"Wanzongshun (Vincent)" <wanzongshun@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver
Date: Wed, 7 Dec 2016 21:20:39 +0100 [thread overview]
Message-ID: <20161207202039.GA27878@ravnborg.org> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020DA1528DE@DGGEMA505-MBX.china.huawei.com>
On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote:
> I don't think the root cause of those warnings are introduced by virtio-crypto driver.
>
> What's your opinion? Sam and David?
Root cause here is that arch/sparc/include/asm/topology_64.h
references cpu_data without including arch/sparc/include/asm/cpudata.h
I think other architectures pull in the dependency from
either smp.h or they have it topology.h.
The easy fix would be to include cpudata.h in arch/sparc/include/asm/topology_64.h.
And that should also be a correct fix.
Could you include this in your patch-set and build test it?
Sam
next prev parent reply other threads:[~2016-12-07 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 12:39 [Qemu-devel] [PATCH v5 0/1] virtio-crypto: add Linux driver Gonglei
2016-12-01 12:39 ` [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver Gonglei
2016-12-04 2:39 ` kbuild test robot
2016-12-05 3:12 ` Gonglei (Arei)
2016-12-07 20:20 ` Sam Ravnborg [this message]
2016-12-08 2:10 ` Gonglei (Arei)
2016-12-06 9:01 ` Gonglei (Arei)
2016-12-07 9:48 ` Herbert Xu
2016-12-08 2:00 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207202039.GA27878@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Claudio.Fontana@huawei.com \
--cc=arei.gonglei@hotmail.com \
--cc=arei.gonglei@huawei.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=hanweidong@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jianjay.zhou@huawei.com \
--cc=kbuild-all@01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=longpeng2@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wanzongshun@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xin.zeng@intel.com \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).