qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] migration: Introduce a new "--only-migratable" option
Date: Thu, 8 Dec 2016 19:59:55 +0000	[thread overview]
Message-ID: <20161208195955.GG2054@work-vm> (raw)
In-Reply-To: <CAC2QTZa8paD4kaY+fWqwWiAu9NKsCTZr9-=Ldn78HPHAUE1ZSA@mail.gmail.com>

* Ashijeet Acharya (ashijeetacharya@gmail.com) wrote:
> Hi Dave,
> 
> I have added the compatibility of this option for both command line
> and hotplug via qmp and hmp. Although, please confirm that making use
> of "device_add" is the only way of hotplugging devices into a QEMU
> instance.

Hmm; there's obsolete commands like usb_add and netdev_add as well.

> With this sorted out, there is one special case left where the device
> dynamically declares itself 'unmigratable' via migrate_add_blocker. I
> have a query regarding that which is, what is the preferred action in
> this scenario? Should I unmount the device or restrict the device from
> becoming unmigratable in the first place.
> For example, restrict 9pfs from mounting the filesystem (which you
> explained previously).
> 
> Or is there a completely different solution in your mind?

My preferred solution is to stop the device getting into the unmigratable
state; so whatever function tries to set it should fail (nicely) and
give an error - e.g the 9pfs should refuse to mount.  I'm not sure
how hard that is.

Dave

> Thanks
> Ashijeet
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2016-12-08 20:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 17:59 [Qemu-devel] migration: Introduce a new "--only-migratable" option Ashijeet Acharya
2016-12-08 19:59 ` Dr. David Alan Gilbert [this message]
2016-12-08 22:18   ` John Snow
2016-12-09  9:10     ` Dr. David Alan Gilbert
2016-12-12 10:46   ` Ashijeet Acharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208195955.GG2054@work-vm \
    --to=dgilbert@redhat.com \
    --cc=ashijeetacharya@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).