qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: mst@redhat.com, aconole@redhat.com, pbonzini@redhat.com,
	qemu-devel@nongnu.org, jasowang@redhat.com,
	yuanhan.liu@linux.intel.com
Cc: fbl@redhat.com, berrange@redhat.com, mlureau@redhat.com,
	ktraynor@redhat.com, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/3] virtio-net: Add support to MTU feature
Date: Sat, 10 Dec 2016 16:30:35 +0100	[thread overview]
Message-ID: <20161210153038.9184-1-maxime.coquelin@redhat.com> (raw)

Thanks for the reviews,

This series implements Virtio spec update from Aaron Conole which
defines a way for the host to expose its max MTU to the guest.

"host_mtu" parameter is added to provide QEMU with the MTU value,
and the backend, if supported, gets notified of the MTU value when the
MTU feature neogotiation succeeds.

Only user backend currently supports MTU notification. A new protocol
feature has been implemented for sending MTU value to the backend.

For kernel backend, it is expected the management tool also configures
the tap/macvtap interface with same MTU value.
Daniel, I would be interrested about your feedback on this implementation
from management tool point of view.

Changes since RFC v3:
---------------------
 - No more RFC as consensus seems found on design
 - No more report an error if backend not implemented
 - Instead, check reply from the backend if REPLY_ACK supported
 - Add NET previx to new protocol feature & request names
 - Add return value to vhost_net_set_mtu() when !CONFIG_VHOST_NET

Changes since RFC v2:
---------------------
 - host_mtu propoerty is now used to specify the MTU value
 - update vhost-user spec with MTU additions

Changes since RFC v1:
---------------------
 - Rebased on top of v2.8.0-rc0 (2.7.90)
 - Write MTU unconditionnaly in netcfg to avoid memory leak (Paolo)
 - Add host_mtu property to be able to disable the feature from QEMU

Maxime Coquelin (3):
  vhost-user: Add MTU protocol feature and op
  vhost-net: Notify the backend about the host MTU
  virtio-net: Add MTU feature support

 docs/specs/vhost-user.txt         | 16 ++++++++++++++++
 hw/net/vhost_net.c                | 18 ++++++++++++++++++
 hw/net/virtio-net.c               | 19 +++++++++++++++++++
 hw/virtio/vhost-user.c            | 34 ++++++++++++++++++++++++++++++++++
 include/hw/virtio/vhost-backend.h |  2 ++
 include/hw/virtio/virtio-net.h    |  1 +
 include/net/vhost_net.h           |  2 ++
 7 files changed, 92 insertions(+)

-- 
2.9.3

             reply	other threads:[~2016-12-10 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10 15:30 Maxime Coquelin [this message]
2016-12-10 15:30 ` [Qemu-devel] [PATCH v4 1/3] vhost-user: Add MTU protocol feature and op Maxime Coquelin
2016-12-10 15:30 ` [Qemu-devel] [PATCH v4 2/3] vhost-net: Notify the backend about the host MTU Maxime Coquelin
2016-12-10 15:30 ` [Qemu-devel] [PATCH v4 3/3] virtio-net: Add MTU feature support Maxime Coquelin
2016-12-12 10:02 ` [Qemu-devel] [PATCH v4 0/3] virtio-net: Add support to MTU feature Daniel P. Berrange
2016-12-12 10:12   ` Maxime Coquelin
2016-12-12 10:34     ` Daniel P. Berrange
2016-12-13 13:04       ` Maxime Coquelin
2016-12-13 13:07         ` Daniel P. Berrange
2016-12-13 13:17           ` Maxime Coquelin
2017-01-10  3:43             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161210153038.9184-1-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=aconole@redhat.com \
    --cc=berrange@redhat.com \
    --cc=fbl@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=ktraynor@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).