qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Ashijeet Acharya" <ashijeetacharya@gmail.com>,
	"John Snow" <jsnow@redhat.com>,
	"Amit Shah" <amit.shah@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option
Date: Thu, 15 Dec 2016 19:39:32 +0000	[thread overview]
Message-ID: <20161215193932.GB16467@work-vm> (raw)
In-Reply-To: <CAFEAcA8XtikQ54QN1dgCFjwntc==FxRnUH17Hh+NWdJc0aNWMg@mail.gmail.com>

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On 15 December 2016 at 19:03, Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> > One thing we'd have to do if we did that would be to
> > add another flag to devices to declare that they might
> > sometime in the future call the migrate_add_blocker.
> 
> ...do you have a third-party library to suggest for
> the "foretell the future" functionality necessary
> for devices to implement this correctly? :-)

No, but it'll be available shortly.....

No, what I mean is there are actually three classes of devices:

    a) Devices that are always migratable
    b) Devices that are never migratable (i.e. set the flag in their
       device structure)
    c) Devices that dont have the flag set but sometimes
       based on the action of the guest call migrate_add_blocker.

If you wanted to make it introspectable in this way then you'd
have to add another flag to the device state so that (c) type
devices could be spotted in the introsepction - although
there's no good way to describe well if it's going to be unmigratable
most of the time (e.g. a 9pfs device that's mounted) or only
doing something odd.

Dave

> thanks
> -- PMM
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

      reply	other threads:[~2016-12-15 19:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 19:06 [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option Ashijeet Acharya
2016-12-14 19:07 ` [Qemu-devel] [PATCH 1/3] migration: Add a new option to enable only-migratable Ashijeet Acharya
2016-12-15 15:29   ` Dr. David Alan Gilbert
2016-12-15 16:48     ` Ashijeet Acharya
2016-12-15 16:50       ` Dr. David Alan Gilbert
2016-12-14 19:07 ` [Qemu-devel] [PATCH 2/3] migration: Allow "device add" options to only add migratable devices Ashijeet Acharya
2016-12-15 16:05   ` Dr. David Alan Gilbert
2016-12-15 16:10     ` Ashijeet Acharya
2016-12-15 16:19       ` Dr. David Alan Gilbert
2016-12-15 16:36         ` Ashijeet Acharya
2016-12-14 19:07 ` [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration Ashijeet Acharya
2016-12-15 17:11   ` Dr. David Alan Gilbert
2016-12-15 17:51     ` John Snow
2016-12-15 18:12       ` Ashijeet Acharya
2016-12-15 15:57 ` [Qemu-devel] [PATCH 0/3] Introduce a new --only-migratable option Michael S. Tsirkin
2016-12-15 16:07   ` Dr. David Alan Gilbert
2016-12-15 16:16     ` Ashijeet Acharya
2016-12-15 18:53     ` Michael S. Tsirkin
2016-12-15 19:03       ` Dr. David Alan Gilbert
2016-12-15 19:16         ` Peter Maydell
2016-12-15 19:39           ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161215193932.GB16467@work-vm \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=ashijeetacharya@gmail.com \
    --cc=groug@kaod.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).