From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7641DC4363A for ; Mon, 26 Oct 2020 12:49:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BC1B22409 for ; Mon, 26 Oct 2020 12:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="YiR+URpL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BC1B22409 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX1wM-0005Wl-Bv for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 08:49:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX1ve-00052p-E9 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 08:48:50 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]:36385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX1vc-0000UI-2i for qemu-devel@nongnu.org; Mon, 26 Oct 2020 08:48:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=2wVUx/dEXT5j8vDkjDfboTerhCnUMngELlzSqWSYGf4=; b=YiR+URpLqYiK4z5V5YGOCMyxE8 IBcz1ixUe79FHvkSffjlaORm+KTLW/MIcVyd2y3Q6nc9aFgkVDyJHVf64SqDDSZzO11RwUDPt44DU /MOjpRoNoImn6qMAv4frjTOHsd0lqRzso+mGCuqMjs9ehBCPC4PgQP1yQiHktIyU4h32wgOs4UQAX hKMaEja5Er13N/qyKBiELxiZ+DElmVHWjp5ffqS3exW5pMxtO3PyMzvPASpBuwNdxlsKL+iLGZsVN QOE8TDC/YQ+lrD8VA73SIxLOXqdyFNtAZp77gm2Hu4m3kRGnMdeZ8RAP3laIQ4cN7SXIbTuOYZA7C sOLZcjvw==; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Peter Maydell , Greg Kurz Subject: Re: [PULL 00/13] 9p queue 2020-10-23 Date: Mon, 26 Oct 2020 13:48:37 +0100 Message-ID: <2016477.jJ6Bm08OSA@silver> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=91.194.90.13; envelope-from=qemu_oss@crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 08:48:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Montag, 26. Oktober 2020 11:33:42 CET Peter Maydell wrote: > On Fri, 23 Oct 2020 at 12:46, Christian Schoenebeck > > wrote: > > The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430: > > Merge remote-tracking branch > > 'remotes/kraxel/tags/modules-20201022-pull-request' into staging > > (2020-10-22 12:33:21 +0100)> > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201023 > > > > for you to fetch changes up to ee01926a11b1f9bffcd6cdec0961dd9d1882da71: > > tests/9pfs: add local Tunlinkat hard link test (2020-10-22 20:26:33 > > +0200) > > > > ---------------------------------------------------------------- > > 9pfs: more tests using local fs driver > > > > Only 9pfs test case changes this time: > > > > * Refactor: Rename functions to make top-level test functions fs_*() > > > > easily distinguishable from utility test functions do_*(). > > > > * Refactor: Drop unnecessary function arguments in utility test > > > > functions. > > > > * More test cases using the 9pfs 'local' filesystem driver backend, > > > > namely for the following 9p requests: Tunlinkat, Tlcreate, Tsymlink > > and Tlink. > > > > ---------------------------------------------------------------- > > I get a 'make check' failure on x86-64 Linux host: > > PASS 54 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/config PASS 55 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/create_dir PASS 56 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/unlinkat_dir PASS 57 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/create_file PASS 58 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/unlinkat_file PASS 59 qtest-x86_64: qos-test > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio- > 9p-tests/local/symlink_file Received response 7 (RLERROR) instead of 73 > (RMKDIR) > Rlerror has errno 2 (No such file or directory) > ** > ERROR:../../tests/qtest/virtio-9p-test.c:300:v9fs_req_recv: assertion > failed (hdr.id == id): (7 == 73) > ERROR qtest-x86_64: qos-test - Bail out! > ERROR:../../tests/qtest/virtio-9ptest.c:300:v9fs_req_recv: assertion > failed (hdr.id == id): (7 == 73) > Makefile.mtest:3953: recipe for target 'run-test-492' failed > > > thanks > -- PMM So the 9p server is already failing to create the test case directory "./qtest-9p-local/05/" relative to your current working directory. I would appreciate to get more info when you have some free cycles, as I'm unable to reproduce this on any system unfortunately. But no hurry as these tests only become relevant actually for QEMU 6. What puzzles me is that the previous test cases succeeded there, which all create their own test directory in the same way: ./qtest-9p-local/01/ ./qtest-9p-local/02/ (<-- dir vanishes after that test completed) ./qtest-9p-local/03/ ./qtest-9p-local/04/ ... How does the "./qtest-9p-local/" directory look like after that "local/symlink_file" test failed there? You can use this shortcut: export QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 cd build tests/qtest/qos-test --verbose ls -l qtest-9p-local That latter qos-test run will also output the assembled qemu command line the 9p local tests would run with, which might also be helpful, e.g. the relevant output would be something like this: GTest: run: /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio-9p-tests/local/config (MSG: starting QEMU: exec x86_64-softmmu/qemu-system-x86_64 -qtest unix:/tmp/qtest-7428.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-7428.qmp,id=char0 -mon chardev=char0,mode=control -display none -M pc -fsdev local,id=fsdev0,path='/home/me/git/qemu/build/qtest-9p-local',security_model=mapped-xattr -device virtio-9p-pci,fsdev=fsdev0,addr=04.0,mount_tag=qtest -accel qtest) Would probably the test succeed if run alone? tests/qtest/qos-test -p /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/virtio-9p/virtio-9p-tests/local/symlink_file Best regards, Christian Schoenebeck