qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de, peter.maydell@linaro.org,
	qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] hw/ppc: QOM'ify spapr_vio.c
Date: Tue, 3 Jan 2017 09:28:46 +1100	[thread overview]
Message-ID: <20170102222846.GC12761@umbus.fritz.box> (raw)
In-Reply-To: <20161231011831.4097-5-zxq_yx_007@163.com>

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Sat, Dec 31, 2016 at 09:18:31AM +0800, xiaoqiang zhao wrote:
> Drop the old and empty SysBus init
> 
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>

This should also actually remove the empty function.

> ---
>  hw/ppc/spapr_vio.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c
> index cc1e09c568..1739b73a13 100644
> --- a/hw/ppc/spapr_vio.c
> +++ b/hw/ppc/spapr_vio.c
> @@ -548,11 +548,9 @@ static int spapr_vio_bridge_init(SysBusDevice *dev)
>  
>  static void spapr_vio_bridge_class_init(ObjectClass *klass, void *data)
>  {
> -    SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>      DeviceClass *dc = DEVICE_CLASS(klass);
>  
>      dc->fw_name = "vdevice";
> -    k->init = spapr_vio_bridge_init;
>  }
>  
>  static const TypeInfo spapr_vio_bridge_info = {

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-01-02 23:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-31  1:18 [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc xiaoqiang zhao
2016-12-31  1:18 ` [Qemu-devel] [PATCH 1/4] hw/gpio: QOM'ify mpc8xxx.c xiaoqiang zhao
2016-12-31  1:18 ` [Qemu-devel] [PATCH 2/4] hw/ppc: QOM'ify e500.c xiaoqiang zhao
2016-12-31  1:18 ` [Qemu-devel] [PATCH 3/4] hw/ppc: QOM'ify ppce500_spin.c xiaoqiang zhao
2016-12-31  1:18 ` [Qemu-devel] [PATCH 4/4] hw/ppc: QOM'ify spapr_vio.c xiaoqiang zhao
2017-01-02 22:28   ` David Gibson [this message]
2017-01-02 22:28 ` [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc David Gibson
2017-01-03 14:02   ` 赵小强
2017-01-04  3:28     ` David Gibson
2017-01-04 13:59       ` 赵小强
2017-01-04 17:04       ` Peter Maydell
2017-01-05  0:20         ` David Gibson
2017-01-05  0:53           ` 赵小强
2017-01-05  1:28             ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102222846.GC12761@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=zxq_yx_007@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).