From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOSL2-0007IM-4w for qemu-devel@nongnu.org; Tue, 03 Jan 2017 11:53:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOSKz-000426-3m for qemu-devel@nongnu.org; Tue, 03 Jan 2017 11:53:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43906) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOSKy-000422-U1 for qemu-devel@nongnu.org; Tue, 03 Jan 2017 11:53:25 -0500 Date: Tue, 3 Jan 2017 17:53:27 +0100 From: Igor Mammedov Message-ID: <20170103175327.61778555@Igors-MacBook-Pro.local> In-Reply-To: References: <20161229223815.13705-1-ehabkost@redhat.com> <20161230152834.6d1fa963@Igors-MacBook-Pro.local> <20161230182308.GK3441@thinpad.lan.raisama.net> <20170103140252.1a2df147@nial.brq.redhat.com> <20170103142223.GB3315@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Eduardo Habkost , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Andreas =?UTF-8?Q?F=C3=A4rber?= On Tue, 3 Jan 2017 17:10:15 +0100 Paolo Bonzini wrote: > > > On 03/01/2017 15:22, Eduardo Habkost wrote: > >> I didn't know that. Is this documented somewhere? > >> Is it actually used by any existing software? > > not that I know of. But users should be fixed if they are not using it. > > > > I see. The problem is that the mechanism is undocumented, > > untested, and seems very likely to trigger bugs in device code. > > I agree. Why can't hotplugged be migrated? It's probably not migrated because of it's not runtime/guest modified state so we don't have to migrate it as it's know in advance. For now it should set manually on CLI (-device) with the rest of hotplugged device properties. > Paolo