From: Igor Mammedov <imammedo@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
ehabkost@redhat.com, armbru@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] cleanup: remove not used header
Date: Tue, 3 Jan 2017 17:54:44 +0100 [thread overview]
Message-ID: <20170103175444.38b824fc@Igors-MacBook-Pro.local> (raw)
In-Reply-To: <dc14b54f-db61-c14c-7963-51d9b322a2a1@suse.de>
On Tue, 3 Jan 2017 16:26:16 +0100
Andreas Färber <afaerber@suse.de> wrote:
> Am 03.01.2017 um 16:25 schrieb Eric Blake:
> > On 01/02/2017 09:44 AM, Igor Mammedov wrote:
> >
> > perhaps s/not used/unused/ in the subject
>
> ... and qom: instead of cleanup: if this gets re-spun.
sure
>
> Andreas
>
> >
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> >
> >> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >> ---
> >> qom/object_interfaces.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> >> index ded4d84..4b880d0 100644
> >> --- a/qom/object_interfaces.c
> >> +++ b/qom/object_interfaces.c
> >> @@ -3,7 +3,6 @@
> >> #include "qom/object_interfaces.h"
> >> #include "qemu/module.h"
> >> #include "qapi-visit.h"
> >> -#include "qapi/qobject-output-visitor.h"
> >> #include "qapi/opts-visitor.h"
> >>
> >> void user_creatable_complete(Object *obj, Error **errp)
> >>
> >
>
>
next prev parent reply other threads:[~2017-01-03 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 15:44 [Qemu-devel] [PATCH 0/3] fix query-memdev not repporting IDs of memory backends Igor Mammedov
2017-01-02 15:44 ` [Qemu-devel] [PATCH 1/3] cleanup: remove not used header Igor Mammedov
2017-01-03 15:25 ` Eric Blake
2017-01-03 15:26 ` Andreas Färber
2017-01-03 16:54 ` Igor Mammedov [this message]
2017-01-02 15:44 ` [Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of user_creatable_add() in monitor Igor Mammedov
2017-01-03 15:29 ` Eric Blake
2017-01-03 15:30 ` Eric Blake
2017-01-02 15:44 ` [Qemu-devel] [PATCH 3/3] fix qmp/hmp query-memdev not repporting IDs of memory backends Igor Mammedov
2017-01-03 15:34 ` Eric Blake
2017-01-03 17:19 ` Igor Mammedov
2017-01-09 14:17 ` Igor Mammedov
2017-01-09 20:26 ` Eric Blake
2017-01-10 9:07 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103175444.38b824fc@Igors-MacBook-Pro.local \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).