From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOilW-0002m7-Kx for qemu-devel@nongnu.org; Wed, 04 Jan 2017 05:25:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOilS-0003fB-VF for qemu-devel@nongnu.org; Wed, 04 Jan 2017 05:25:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59802) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOilS-0003ez-MR for qemu-devel@nongnu.org; Wed, 04 Jan 2017 05:25:50 -0500 Date: Wed, 4 Jan 2017 10:25:40 +0000 From: "Daniel P. Berrange" Message-ID: <20170104102540.GC10541@redhat.com> Reply-To: "Daniel P. Berrange" References: <586c7aad.0834c80a.d7aff.122e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <586c7aad.0834c80a.d7aff.122e@mx.google.com> Subject: Re: [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: qemu-devel@nongnu.org, liqiang6-s@360.cn On Tue, Jan 03, 2017 at 08:31:34PM -0800, Li Qiang wrote: > From: Li Qiang > > On error path, the 'salt' doesn't been freed thus leading > a memory leak. This patch avoid this. > > Signed-off-by: Li Qiang > --- > crypto/ivgen-essiv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c > index 634de63..cba20bd 100644 > --- a/crypto/ivgen-essiv.c > +++ b/crypto/ivgen-essiv.c > @@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen, > &salt, &nhash, > errp) < 0) { > g_free(essiv); > + g_free(salt); > return -1; > } Looks good, thanks, added to the crypto-next queue. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|