* [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror
@ 2017-01-04 14:52 Paolo Bonzini
2017-01-04 17:58 ` Marc-André Lureau
2017-01-12 10:56 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-01-04 14:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
process_command returns a negative value in case of error. Make this
clear in the "if" statement and fix the strerror argument to flip it
to positive.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qga/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 6caf215..538e4ee 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -558,8 +558,8 @@ static void process_command(GAState *s, QDict *req)
rsp = qmp_dispatch(QOBJECT(req));
if (rsp) {
ret = send_response(s, rsp);
- if (ret) {
- g_warning("error sending response: %s", strerror(ret));
+ if (ret < 0) {
+ g_warning("error sending response: %s", strerror(-ret));
}
qobject_decref(rsp);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror
2017-01-04 14:52 [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror Paolo Bonzini
@ 2017-01-04 17:58 ` Marc-André Lureau
2017-01-12 10:56 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2017-01-04 17:58 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
On Wed, Jan 4, 2017 at 3:54 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> process_command returns a negative value in case of error. Make this
> clear in the "if" statement and fix the strerror argument to flip it
> to positive.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> qga/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 6caf215..538e4ee 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -558,8 +558,8 @@ static void process_command(GAState *s, QDict *req)
> rsp = qmp_dispatch(QOBJECT(req));
> if (rsp) {
> ret = send_response(s, rsp);
> - if (ret) {
> - g_warning("error sending response: %s", strerror(ret));
> + if (ret < 0) {
> + g_warning("error sending response: %s", strerror(-ret));
> }
> qobject_decref(rsp);
> }
> --
> 2.9.3
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror
2017-01-04 14:52 [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror Paolo Bonzini
2017-01-04 17:58 ` Marc-André Lureau
@ 2017-01-12 10:56 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-01-12 10:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
04.01.2017 17:52, Paolo Bonzini wrote:
> process_command returns a negative value in case of error. Make this
> clear in the "if" statement and fix the strerror argument to flip it
> to positive.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-04 14:52 [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror Paolo Bonzini
2017-01-04 17:58 ` Marc-André Lureau
2017-01-12 10:56 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).