From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v2 2/2] run_tests: allow run tests in parallel
Date: Wed, 4 Jan 2017 16:09:39 +0100 [thread overview]
Message-ID: <20170104150938.GA9029@potion> (raw)
In-Reply-To: <1483438205-31110-3-git-send-email-peterx@redhat.com>
2017-01-03 18:10+0800, Peter Xu:
> run_task.sh is getting slow. This patch is trying to make it faster by
> running the tests concurrently.
>
> We provide a new parameter "-j" for the run_tests.sh, which can be used
> to specify how many run queues we want for the tests. Default queue
> length is 1, which is the old behavior.
>
> Quick test on my laptop (4 cores, 2 threads each) shows 3x speed boost:
>
> |-----------------+-----------|
> | command | time used |
> |-----------------+-----------|
> | run_test.sh | 75s |
> | run_test.sh -j8 | 27s |
> |-----------------+-----------|
>
> Suggested-by: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> run_tests.sh | 12 ++++++++++--
> scripts/functions.bash | 15 ++++++++++++++-
> scripts/global.bash | 11 +++++++++++
> 3 files changed, 35 insertions(+), 3 deletions(-)
I like this diffstat a lot more, thanks :)
The script doesn't handle ^C well now (at least), which can be worked
around with
trap exit SIGINT
but it would be nice to know if receiving signals in `wait` can't be
fixed.
next prev parent reply other threads:[~2017-01-04 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 10:10 [Qemu-devel] [kvm-unit-tests PATCH v2 0/2] run_tests: support concurrent test execution Peter Xu
2017-01-03 10:10 ` [Qemu-devel] [kvm-unit-tests PATCH v2 1/2] run_tests: put logs into per-test file Peter Xu
2017-01-03 10:10 ` [Qemu-devel] [kvm-unit-tests PATCH v2 2/2] run_tests: allow run tests in parallel Peter Xu
2017-01-03 10:17 ` Peter Xu
2017-01-04 15:09 ` Radim Krčmář [this message]
2017-01-05 3:07 ` Peter Xu
2017-01-05 19:44 ` Radim Krčmář
2017-01-06 3:31 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104150938.GA9029@potion \
--to=rkrcmar@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).