* [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"
@ 2017-01-04 20:57 Marc-André Lureau
2017-01-12 13:25 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: Marc-André Lureau @ 2017-01-04 20:57 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, berrange, Marc-André Lureau
This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4.
The error "Failed to execute helper program (No such file or directory)"
is due to broken glib installation, missing windows gspawn helpers.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 218df87d21..54a222d5e7 100755
--- a/configure
+++ b/configure
@@ -3077,7 +3077,7 @@ fi
# g_test_trap_subprocess added in 2.38. Used by some tests.
glib_subprocess=yes
-if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0; then
+if ! $pkg_config --atleast-version=2.38 glib-2.0; then
glib_subprocess=no
fi
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"
2017-01-04 20:57 [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform" Marc-André Lureau
@ 2017-01-12 13:25 ` Eduardo Habkost
2017-01-12 13:47 ` Vincent Palatin
0 siblings, 1 reply; 4+ messages in thread
From: Eduardo Habkost @ 2017-01-12 13:25 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, berrange
On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote:
> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4.
>
> The error "Failed to execute helper program (No such file or directory)"
> is due to broken glib installation, missing windows gspawn helpers.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Daniel, are you still unable to run subprocess tests on Migw32?
Anybody else able to test this and send a Tested-by line?
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 218df87d21..54a222d5e7 100755
> --- a/configure
> +++ b/configure
> @@ -3077,7 +3077,7 @@ fi
>
> # g_test_trap_subprocess added in 2.38. Used by some tests.
> glib_subprocess=yes
> -if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0; then
> +if ! $pkg_config --atleast-version=2.38 glib-2.0; then
> glib_subprocess=no
> fi
>
> --
> 2.11.0
>
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"
2017-01-12 13:25 ` Eduardo Habkost
@ 2017-01-12 13:47 ` Vincent Palatin
2017-01-12 14:09 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Palatin @ 2017-01-12 13:47 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: Marc-André Lureau, qemu-devel
On Thu, Jan 12, 2017 at 2:25 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote:
>> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4.
>>
>> The error "Failed to execute helper program (No such file or directory)"
>> is due to broken glib installation, missing windows gspawn helpers.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Daniel, are you still unable to run subprocess tests on Migw32?
>
> Anybody else able to test this and send a Tested-by line?
Works on my setup (mingw32-w64 build on Windows 10, with glib-2.46.2)
Tested-by: Vincent Palatin <vpalatin@chromium.org>
>
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 218df87d21..54a222d5e7 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3077,7 +3077,7 @@ fi
>>
>> # g_test_trap_subprocess added in 2.38. Used by some tests.
>> glib_subprocess=yes
>> -if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0; then
>> +if ! $pkg_config --atleast-version=2.38 glib-2.0; then
>> glib_subprocess=no
>> fi
>>
>> --
>> 2.11.0
>>
>
> --
> Eduardo
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"
2017-01-12 13:47 ` Vincent Palatin
@ 2017-01-12 14:09 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2017-01-12 14:09 UTC (permalink / raw)
To: Vincent Palatin; +Cc: Marc-André Lureau, qemu-devel
On Thu, Jan 12, 2017 at 02:47:37PM +0100, Vincent Palatin wrote:
> On Thu, Jan 12, 2017 at 2:25 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote:
> >> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4.
> >>
> >> The error "Failed to execute helper program (No such file or directory)"
> >> is due to broken glib installation, missing windows gspawn helpers.
> >>
> >> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Daniel, are you still unable to run subprocess tests on Migw32?
> >
> > Anybody else able to test this and send a Tested-by line?
>
> Works on my setup (mingw32-w64 build on Windows 10, with glib-2.46.2)
>
> Tested-by: Vincent Palatin <vpalatin@chromium.org>
Thanks! Unless another maintainer is already planning to apply
it, I will include it on my next pull request.
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-12 14:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-04 20:57 [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform" Marc-André Lureau
2017-01-12 13:25 ` Eduardo Habkost
2017-01-12 13:47 ` Vincent Palatin
2017-01-12 14:09 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).