qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900
@ 2016-10-26 19:08 Richard Henderson
  2016-10-27  6:55 ` Thomas Huth
  2017-01-05 12:07 ` Riku Voipio
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2016-10-26 19:08 UTC (permalink / raw)
  To: qemu-devel; +Cc: Riku Voipio

The LT instruction was added in the extended immediate facility
introduced with the z9-109 processor.

Cc: Riku Voipio <riku.voipio@iki.fi>
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
Suggested-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 linux-user/host/s390x/safe-syscall.inc.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
index f1b446a..414b44a 100644
--- a/linux-user/host/s390x/safe-syscall.inc.S
+++ b/linux-user/host/s390x/safe-syscall.inc.S
@@ -72,7 +72,7 @@ safe_syscall_base:
 	 */
 safe_syscall_start:
 	/* if signal_pending is non-zero, don't do the call */
-	lt	%r0,0(%r8)
+	icm	%r0,15,0(%r8)
 	jne	2f
 	svc	0
 safe_syscall_end:
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900
  2016-10-26 19:08 [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900 Richard Henderson
@ 2016-10-27  6:55 ` Thomas Huth
  2017-01-05 12:07 ` Riku Voipio
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2016-10-27  6:55 UTC (permalink / raw)
  To: Richard Henderson, qemu-devel; +Cc: Riku Voipio, Michael Tokarev

On 26.10.2016 21:08, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.
> 
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
> Suggested-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  linux-user/host/s390x/safe-syscall.inc.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
> index f1b446a..414b44a 100644
> --- a/linux-user/host/s390x/safe-syscall.inc.S
> +++ b/linux-user/host/s390x/safe-syscall.inc.S
> @@ -72,7 +72,7 @@ safe_syscall_base:
>  	 */
>  safe_syscall_start:
>  	/* if signal_pending is non-zero, don't do the call */
> -	lt	%r0,0(%r8)
> +	icm	%r0,15,0(%r8)
>  	jne	2f
>  	svc	0
>  safe_syscall_end:

Reviewed-by: Thomas Huth <thuth@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900
  2016-10-26 19:08 [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900 Richard Henderson
  2016-10-27  6:55 ` Thomas Huth
@ 2017-01-05 12:07 ` Riku Voipio
  1 sibling, 0 replies; 3+ messages in thread
From: Riku Voipio @ 2017-01-05 12:07 UTC (permalink / raw)
  To: Richard Henderson; +Cc: qemu-devel

On Wed, Oct 26, 2016 at 12:08:52PM -0700, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.

Sorry I missed this during 2.8. This is stable-2.8 material once it
opens. Applied to linux-user now, thanks.
 
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
> Suggested-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  linux-user/host/s390x/safe-syscall.inc.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
> index f1b446a..414b44a 100644
> --- a/linux-user/host/s390x/safe-syscall.inc.S
> +++ b/linux-user/host/s390x/safe-syscall.inc.S
> @@ -72,7 +72,7 @@ safe_syscall_base:
>  	 */
>  safe_syscall_start:
>  	/* if signal_pending is non-zero, don't do the call */
> -	lt	%r0,0(%r8)
> +	icm	%r0,15,0(%r8)
>  	jne	2f
>  	svc	0
>  safe_syscall_end:
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-05 12:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 19:08 [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900 Richard Henderson
2016-10-27  6:55 ` Thomas Huth
2017-01-05 12:07 ` Riku Voipio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).