qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Jin Guojie <jinguojie@loongson.cn>
Subject: [Qemu-devel] [PULL 06/11] tcg-mips: Adjust load/store functions for mips64
Date: Sun,  8 Jan 2017 09:56:15 -0800	[thread overview]
Message-ID: <20170108175620.6605-7-rth@twiddle.net> (raw)
In-Reply-To: <20170108175620.6605-1-rth@twiddle.net>

From: Jin Guojie <jinguojie@loongson.cn>

tcg_out_ldst: using a generic ALIAS_PADD to avoid ifdefs
tcg_out_ld: generates LD or LW
tcg_out_st: generates SD or SW

Tested-by: Aurelien Jarno <aurelien@aurel32.net>
Tested-by: James Hogan <james.hogan@imgtec.com>
Tested-by: YunQiang Su <wzssyqa@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Jin Guojie <jinguojie@loongson.cn>
Message-Id: <1483592275-4496-7-git-send-email-jinguojie@loongson.cn>
---
 tcg/mips/tcg-target.inc.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
index 18368f0..5cc8df3 100644
--- a/tcg/mips/tcg-target.inc.c
+++ b/tcg/mips/tcg-target.inc.c
@@ -697,7 +697,7 @@ static void tcg_out_ldst(TCGContext *s, MIPSInsn opc, TCGReg data,
     if (ofs != lo) {
         tcg_out_movi(s, TCG_TYPE_PTR, TCG_TMP0, ofs - lo);
         if (addr != TCG_REG_ZERO) {
-            tcg_out_opc_reg(s, OPC_ADDU, TCG_TMP0, TCG_TMP0, addr);
+            tcg_out_opc_reg(s, ALIAS_PADD, TCG_TMP0, TCG_TMP0, addr);
         }
         addr = TCG_TMP0;
     }
@@ -707,13 +707,21 @@ static void tcg_out_ldst(TCGContext *s, MIPSInsn opc, TCGReg data,
 static inline void tcg_out_ld(TCGContext *s, TCGType type, TCGReg arg,
                               TCGReg arg1, intptr_t arg2)
 {
-    tcg_out_ldst(s, OPC_LW, arg, arg1, arg2);
+    MIPSInsn opc = OPC_LD;
+    if (TCG_TARGET_REG_BITS == 32 || type == TCG_TYPE_I32) {
+        opc = OPC_LW;
+    }
+    tcg_out_ldst(s, opc, arg, arg1, arg2);
 }
 
 static inline void tcg_out_st(TCGContext *s, TCGType type, TCGReg arg,
                               TCGReg arg1, intptr_t arg2)
 {
-    tcg_out_ldst(s, OPC_SW, arg, arg1, arg2);
+    MIPSInsn opc = OPC_SD;
+    if (TCG_TARGET_REG_BITS == 32 || type == TCG_TYPE_I32) {
+        opc = OPC_SW;
+    }
+    tcg_out_ldst(s, opc, arg, arg1, arg2);
 }
 
 static inline bool tcg_out_sti(TCGContext *s, TCGType type, TCGArg val,
-- 
2.9.3

  parent reply	other threads:[~2017-01-08 17:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08 17:56 [Qemu-devel] [PULL 00/11] tcg host mips64 support Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 01/11] tcg-mips: Move bswap code to a subroutine Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 02/11] tcg-mips: Add mips64 opcodes Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 03/11] tcg-mips: Support 64-bit opcodes Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 04/11] tcg-mips: Add bswap32u and bswap64 Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 05/11] tcg-mips: Adjust move functions for mips64 Richard Henderson
2017-01-08 17:56 ` Richard Henderson [this message]
2017-01-08 17:56 ` [Qemu-devel] [PULL 07/11] tcg-mips: Adjust prologue " Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 08/11] tcg-mips: Add tcg unwind info Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 09/11] tcg-mips: Adjust calling conventions for mips64 Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 10/11] tcg-mips: Adjust qemu_ld/st " Richard Henderson
2017-01-08 17:56 ` [Qemu-devel] [PULL 11/11] translate-all: Avoid -Werror=switch-bool Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170108175620.6605-7-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=jinguojie@loongson.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).