qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Jin Guojie <jinguojie@loongson.cn>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] Change default CFLAGS to -O3
Date: Mon, 9 Jan 2017 11:18:35 +0000	[thread overview]
Message-ID: <20170109111835.GE29989@redhat.com> (raw)
In-Reply-To: <20170109100123.5080-2-jinguojie@loongson.cn>

On Mon, Jan 09, 2017 at 06:01:23PM +0800, Jin Guojie wrote:
> For better performance.

The commit message needs to have actual data on what the
measured performance improvements are really.

> 
> Signed-off-by: Jin Guojie <jinguojie@loongson.cn>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 218df87..8ebc286 100755
> --- a/configure
> +++ b/configure
> @@ -4753,9 +4753,9 @@ if test "$gcov" = "yes" ; then
>    CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
>    LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
>  elif test "$fortify_source" = "yes" ; then
> -  CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
> +  CFLAGS="-O3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
>  elif test "$debug" = "no"; then
> -  CFLAGS="-O2 $CFLAGS"
> +  CFLAGS="-O3 $CFLAGS"
>  fi

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

  reply	other threads:[~2017-01-09 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 10:01 [Qemu-devel] [PATCH 0/1] Change default CFLAGS to -O3 Jin Guojie
2017-01-09 10:01 ` [Qemu-devel] [PATCH 1/1] " Jin Guojie
2017-01-09 11:18   ` Daniel P. Berrange [this message]
2017-01-09 10:33 ` [Qemu-devel] [PATCH 0/1] " Peter Maydell
2017-01-09 11:09 ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109111835.GE29989@redhat.com \
    --to=berrange@redhat.com \
    --cc=jinguojie@loongson.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).