From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress
Date: Mon, 9 Jan 2017 15:39:07 +0000 [thread overview]
Message-ID: <20170109153914.27424-2-berrange@redhat.com> (raw)
In-Reply-To: <20170109153914.27424-1-berrange@redhat.com>
Add a 'numeric' flag to the InetSocketAddress struct to allow the
caller to indicate that DNS should be skipped for the host/port
fields. This is useful if the caller knows the address is already
numeric and wants to guarantee no (potentially blocking) DNS
lookups are attempted.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
qapi-schema.json | 5 +++++
util/qemu-sockets.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index a0d3b5d..d59f8cc 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3070,6 +3070,10 @@
#
# @port: port part of the address, or lowest port if @to is present
#
+# @numeric: #optional true if the host/port are guaranteed to be numeric,
+# false if name resolution should be attempted. Defaults to false.
+# (Since 2.9)
+#
# @to: highest port to try
#
# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
@@ -3084,6 +3088,7 @@
'data': {
'host': 'str',
'port': 'str',
+ '*numeric': 'bool',
'*to': 'uint16',
'*ipv4': 'bool',
'*ipv6': 'bool' } }
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index fe1d07a..d63b011 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -141,6 +141,9 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
memset(&ai,0, sizeof(ai));
ai.ai_flags = AI_PASSIVE;
+ if (saddr->has_numeric && saddr->numeric) {
+ ai.ai_flags |= AI_NUMERICHOST | AI_NUMERICSERV;
+ }
ai.ai_family = inet_ai_family_from_address(saddr, &err);
ai.ai_socktype = SOCK_STREAM;
--
2.9.3
next prev parent reply other threads:[~2017-01-09 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 15:39 [Qemu-devel] [PATCH v2 0/8] io: enable DNS resolving separately of socket create Daniel P. Berrange
2017-01-09 15:39 ` Daniel P. Berrange [this message]
2017-01-10 14:25 ` [Qemu-devel] [PATCH v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress Eric Blake
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 2/8] io: stop incrementing reference in qio_task_get_source Daniel P. Berrange
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 3/8] io: fix typo in docs for QIOTask Daniel P. Berrange
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 4/8] io: add ability to associate an opaque "result" with with a task Daniel P. Berrange
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error " Daniel P. Berrange
2017-01-10 14:55 ` Eric Blake
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 6/8] io: change the QIOTask callback signature Daniel P. Berrange
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 7/8] io: remove Error parameter from QIOTask thread worker Daniel P. Berrange
2017-01-09 15:39 ` [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API Daniel P. Berrange
2017-01-10 15:01 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109153914.27424-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).