From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQtHk-0002M9-Ts for qemu-devel@nongnu.org; Tue, 10 Jan 2017 05:04:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQtHe-0006sA-Vb for qemu-devel@nongnu.org; Tue, 10 Jan 2017 05:04:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cQtHe-0006rv-Pw for qemu-devel@nongnu.org; Tue, 10 Jan 2017 05:04:02 -0500 Date: Tue, 10 Jan 2017 10:03:55 +0000 From: "Daniel P. Berrange" Message-ID: <20170110100355.GD27720@redhat.com> Reply-To: "Daniel P. Berrange" References: <58733617.3050503@huawei.com> <20170109134310.GE30228@stefanha-x1.localdomain> <20170109162504.GH29989@redhat.com> <33183CC9F5247A488A2544077AF19020DA182982@DGGEMA505-MBX.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020DA182982@DGGEMA505-MBX.china.huawei.com> Subject: Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: Stefan Hajnoczi , longpeng , Paolo Bonzini , QEMU-DEV , "Wubin (H)" , "Zhoujian (jay, Euler)" On Tue, Jan 10, 2017 at 09:03:45AM +0000, Gonglei (Arei) wrote: > Hi, > > > > > On Mon, Jan 09, 2017 at 01:43:10PM +0000, Stefan Hajnoczi wrote: > > > On Mon, Jan 09, 2017 at 03:04:55PM +0800, Longpeng (Mike) wrote: > > > > I'm one of Gonglei's virtio-crypto project members, and we plan to add a > > AF_ALG > > > > backend for virtio-crypto(there's only builtin-backend currently). > > > > > > > > I found that Catalin, Paolo and Stefan had discussed about this in 2015 > > > > (http://www.spinics.net/lists/kvm/msg115457.html), but it seems that > > Catalin > > > > didn't do it, so I'm confuse about wether it is need to add a AF_ALG > > backend. > > > > > > > > Do you have any suggestion? Thanks :) > > > > > > I have no objections to an AF_ALG backend in QEMU. > > > > Rather than do another backend for virtio-crypto, IMHO, we should have > > an AF_ALG impl of the crypto/ APIs. That way any potential performance > > benefits will enhance our LUKS encryption code too. > > > According to the currently schemas of crypto/ APIs, we can't choose the > specific backend dynamically. This is a limitation for virtio-crypto > device I think. Do we really need to be able to choose the backend explicitly. If the AF_ALG backend is faster, why would you simply not use that automatically if it is available. I'm not seeing an obvious need for dynamically choosing between backends. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|