From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer
Date: Thu, 12 Jan 2017 10:58:54 +0000 [thread overview]
Message-ID: <20170112105854.GE4621@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170111094443.2790-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Wed, Jan 11, 2017 at 09:44:43AM +0000, Stefan Hajnoczi wrote:
> Unlike g_free(), g_array_free() does not accept a NULL pointer argument.
> The following error is logged when an nvdimm device is realized:
>
> GLib-CRITICAL **: g_array_free: assertion 'array' failed
>
> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/acpi/nvdimm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
NACK
Guangrong pointed out this patch is masking another bug. There seems to
be a problem with the order in which functions are called when the
device is realized.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-01-12 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 9:44 [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer Stefan Hajnoczi
2017-01-11 16:08 ` Igor Mammedov
2017-01-12 10:58 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-11 9:36 Stefan Hajnoczi
2017-01-12 3:18 ` Xiao Guangrong
2017-01-12 11:09 ` Stefan Hajnoczi
2017-01-13 0:50 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112105854.GE4621@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).