From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Andrew Jones" <drjones@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file
Date: Thu, 12 Jan 2017 22:14:00 +0800 [thread overview]
Message-ID: <20170112141400.GS4450@pxdev.xzpeter.org> (raw)
In-Reply-To: <5269cdb1-ae12-31af-0e7d-7c8d2b9c6848@redhat.com>
On Thu, Jan 12, 2017 at 01:55:48PM +0100, Paolo Bonzini wrote:
[...]
> > diff --git a/scripts/functions.bash b/scripts/common.bash
> > similarity index 75%
> > rename from scripts/functions.bash
> > rename to scripts/common.bash
> > index ee9143c..2dd7360 100644
> > --- a/scripts/functions.bash
> > +++ b/scripts/common.bash
> > @@ -1,3 +1,12 @@
> > +: ${unittest_log_dir:=logs}
> > +
> > +function run_task()
> > +{
> > + local testname="$2"
> > +
> > + RUNTIME_log_file="${unittest_log_dir}/${testname}.log"
> > + "$@"
> > +}
>
> This should go in run_tests.sh since that's the only place that uses
> unittest_log_dir. (The last line then becomes 'run "$@"' and the
> for_each_unittest call must be adjusted). Done and queued.
Yes, this should be cleaner. Thanks,
-- peterx
next prev parent reply other threads:[~2017-01-12 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 3:36 [Qemu-devel] [kvm-unit-tests PATCH v6 0/3] run_tests: support concurrent test execution Peter Xu
2017-01-12 3:36 ` [Qemu-devel] [kvm-unit-tests PATCH v6 1/3] run_tests: fix errno for param parsing Peter Xu
2017-01-12 11:42 ` Andrew Jones
2017-01-12 3:36 ` [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file Peter Xu
2017-01-12 10:04 ` Andrew Jones
2017-01-12 10:35 ` Peter Xu
2017-01-12 12:55 ` Paolo Bonzini
2017-01-12 14:14 ` Peter Xu [this message]
2017-01-12 3:36 ` [Qemu-devel] [kvm-unit-tests PATCH v6 3/3] run_tests: allow run tests in parallel Peter Xu
2017-01-12 11:42 ` Andrew Jones
2017-01-12 13:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112141400.GS4450@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).