From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRgPA-0002OB-PV for qemu-devel@nongnu.org; Thu, 12 Jan 2017 09:31:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRgP5-0000m5-TQ for qemu-devel@nongnu.org; Thu, 12 Jan 2017 09:31:04 -0500 Date: Thu, 12 Jan 2017 16:30:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20170112163009-mutt-send-email-mst@kernel.org> References: <20170111173457.30455-1-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111173457.30455-1-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 wave 1 0/4] fw-cfg: support writeable blobs and more files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu devel list , "Gabriel L. Somlo" , Alexander Graf , Anthony Perard , Artyom Tarasenko , David Gibson , Eduardo Habkost , Gerd Hoffmann , Igor Mammedov , Mark Cave-Ayland , Michael Walle , Paolo Bonzini , Peter Maydell , Shannon Zhao , Stefano Stabellini , qemu-arm@nongnu.org On Wed, Jan 11, 2017 at 06:34:53PM +0100, Laszlo Ersek wrote: > This is the first (fw_cfg) half of the v5 iteration of the series posted > here: > . > > In this version, the fw_cfg patches have been separated into a > standalone "wave", for helping review / maintenance, and also for > enabling independent features on top of writeable blobs. More > importantly, I've addressed Igor's v4 feedback. See the individual > patches for the details. > > Patch #3 is included verbatim from Eduardo's pending series (see the > patch notes for the archive URL), as a dependency for patch #4. If > Eduardo's series is merged first, patch #3 can be dropped (in fact > git-rebase should do it automatically). > > Please excuse the surprisingly long list of CC's, it's due to the fact > that fw_cfg is quite widely used (see patch #4). Looks good. So what's the plan for merging this? I think I'll merge part 1 and then Paolo merges part 2 - is that what you had in mind? > Cc: "Gabriel L. Somlo" > Cc: "Michael S. Tsirkin" > Cc: Alexander Graf > Cc: Anthony Perard > Cc: Artyom Tarasenko > Cc: David Gibson > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Laszlo Ersek > Cc: Mark Cave-Ayland > Cc: Michael Walle > Cc: Paolo Bonzini > Cc: Peter Maydell > Cc: Shannon Zhao > Cc: Stefano Stabellini > Cc: qemu-arm@nongnu.org > > Thanks > Laszlo > > > Eduardo Habkost (1): > pc: Add 2.9 machine-types > > Laszlo Ersek (2): > fw-cfg: turn FW_CFG_FILE_SLOTS into a device property > fw-cfg: bump "file_slots" to 0x20 for 2.9+ machine types > > Michael S. Tsirkin (1): > fw-cfg: support writeable blobs > > docs/specs/fw_cfg.txt | 36 ++++++++++---- > hw/lm32/lm32_hwsetup.h | 2 +- > include/hw/compat.h | 10 +++- > include/hw/i386/pc.h | 2 + > include/hw/loader.h | 7 +-- > include/hw/nvram/fw_cfg.h | 3 +- > include/hw/nvram/fw_cfg_keys.h | 3 +- > hw/arm/virt-acpi-build.c | 2 +- > hw/core/loader.c | 18 ++++--- > hw/i386/acpi-build.c | 4 +- > hw/i386/pc_piix.c | 15 ++++-- > hw/i386/pc_q35.c | 13 ++++- > hw/nvram/fw_cfg.c | 110 +++++++++++++++++++++++++++++++++++------ > 13 files changed, 177 insertions(+), 48 deletions(-) > > -- > 2.9.3