From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRkJq-000168-D2 for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:41:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRkJn-0001HL-8r for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:41:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45512) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRkJn-0001H5-2T for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:41:47 -0500 Date: Thu, 12 Jan 2017 16:41:43 -0200 From: Eduardo Habkost Message-ID: <20170112184143.GS3565@thinpad.lan.raisama.net> References: <20170112182417.9548-1-lersek@redhat.com> <20170112182417.9548-5-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112182417.9548-5-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 wave 1 4/4] fw-cfg: bump "x-file-slots" to 0x20 for 2.9+ machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu devel list , "Gabriel L. Somlo" , "Michael S. Tsirkin" , Alexander Graf , Anthony Perard , Artyom Tarasenko , David Gibson , Gerd Hoffmann , Igor Mammedov , Mark Cave-Ayland , Paolo Bonzini , Peter Maydell , Stefano Stabellini On Thu, Jan 12, 2017 at 07:24:17PM +0100, Laszlo Ersek wrote: > More precisely, the "x-file-slots" count is bumped for all machine types > that: > (a) use fw_cfg, and > (b) are not versioned (hence migration is not expected to work for them > across QEMU releases anyway), or have version 2.9. > > This affects machine types implemented in the following source files: > > - "hw/arm/virt.c". The "virt-*" machine type is versioned, and the <= 2.8 > versions already depend on HW_COMPAT_2_8 (see commit e353aac51b944). > Therefore adding the "x-file-slots" compat values to HW_COMPAT_2_8 > suffices. > > - "hw/i386/pc.c". The "pc-i440fx-*" (including "pc-*") and "pc-q35-*" > machine types are versioned. Modifying HW_COMPAT_2_8 is sufficient here > too (see commit "pc: Add 2.9 machine-types"). The "isapc" machtype is > not versioned. The "xenfv" machine type, which uses fw_cfg for direct > kernel booting, is also not versioned. > > - "hw/ppc/mac_newworld.c". The "mac99" machine type is not versioned. > > - "hw/ppc/mac_oldworld.c". The "g3beige" machine type is not versioned. > > - "hw/sparc/sun4m.c". None of the 9 machine types defined in this file > appear versioned. > > - "hw/sparc64/sun4u.c". None of the 3 machine types defined in this file > appear versioned. > > Cc: "Gabriel L. Somlo" > Cc: "Michael S. Tsirkin" > Cc: Alexander Graf > Cc: Anthony Perard > Cc: Artyom Tarasenko > Cc: David Gibson > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Mark Cave-Ayland > Cc: Paolo Bonzini > Cc: Peter Maydell > Cc: Stefano Stabellini > Signed-off-by: Laszlo Ersek > Acked-by: Gabriel Somlo > Tested-by: Gabriel Somlo Reviewed-by: Eduardo Habkost -- Eduardo