From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cS22T-0001V2-2M for qemu-devel@nongnu.org; Fri, 13 Jan 2017 08:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cS22P-0000kR-VY for qemu-devel@nongnu.org; Fri, 13 Jan 2017 08:37:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56368) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cS22P-0000kD-Ok for qemu-devel@nongnu.org; Fri, 13 Jan 2017 08:37:01 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E46CC81240 for ; Fri, 13 Jan 2017 13:37:01 +0000 (UTC) Date: Fri, 13 Jan 2017 14:36:58 +0100 From: Igor Mammedov Message-ID: <20170113143658.1358532f@nial.brq.redhat.com> In-Reply-To: <20170112182446.9600-4-lersek@redhat.com> References: <20170112182446.9600-1-lersek@redhat.com> <20170112182446.9600-4-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu devel list , "Michael S. Tsirkin" , Eduardo Habkost , Gerd Hoffmann , Paolo Bonzini On Thu, 12 Jan 2017 19:24:46 +0100 Laszlo Ersek wrote: > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Paolo Bonzini > Signed-off-by: Laszlo Ersek > Reviewed-by: Eduardo Habkost > Reviewed-by: Michael S. Tsirkin > --- > > Notes: > v6: > - rename "smi_broadcast" to "x-smi-broadcast" [Eduardo] > - pick up Eduardo's R-b > - pick up Michael's R-b > > v5: > - replace the v4 patch "hw/i386/pc_q35: advertise broadcast SMI if VCPU > hotplug is turned off" with a simple device property and compat > setting [Igor] > > include/hw/i386/pc.h | 5 +++++ > hw/isa/lpc_ich9.c | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 230e9e70c504..9d950733abdf 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -376,6 +376,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > > #define PC_COMPAT_2_8 \ > HW_COMPAT_2_8 \ > + {\ > + .driver = "ICH9-LPC",\ > + .property = "x-smi-broadcast",\ > + .value = "off",\ > + },\ > > > #define PC_COMPAT_2_7 \ > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index ced6f803a4f2..59930dd9d09d 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -776,6 +776,8 @@ static const VMStateDescription vmstate_ich9_lpc = { > > static Property ich9_lpc_properties[] = { > DEFINE_PROP_BOOL("noreboot", ICH9LPCState, pin_strap.spkr_hi, true), > + DEFINE_PROP_BIT64("x-smi-broadcast", ICH9LPCState, smi_host_features, > + ICH9_LPC_SMI_F_BROADCAST_BIT, true), > DEFINE_PROP_END_OF_LIST(), > }; > Reviewed-by: Igor Mammedov