From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/6] hypertrace: Add guest-side Linux module
Date: Mon, 16 Jan 2017 10:37:00 +0000 [thread overview]
Message-ID: <20170116103700.GA12351@stefanha-x1.localdomain> (raw)
In-Reply-To: <878tqdysxm.fsf@ac.upc.edu>
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
On Sun, Jan 15, 2017 at 03:10:13AM +0100, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> > On Mon, Dec 26, 2016 at 09:35:10PM +0100, Lluís Vilanova wrote:
> >> Provides guest Linux kernel module "qemu-hypertrace.ko" to abstract
> >> access to the hypertrace channel.
> >>
> >> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> >> ---
> >> Makefile | 4 -
> >> configure | 4 +
> >> hypertrace/guest/linux-module/Kbuild.in | 7 +
> >> hypertrace/guest/linux-module/Makefile | 23 +++
> >> .../include/linux/qemu-hypertrace-internal.h | 46 ++++++
> >> .../linux-module/include/linux/qemu-hypertrace.h | 73 ++++++++++
> >> hypertrace/guest/linux-module/qemu-hypertrace.c | 149 ++++++++++++++++++++
> >> 7 files changed, 305 insertions(+), 1 deletion(-)
> >> create mode 100644 hypertrace/guest/linux-module/Kbuild.in
> >> create mode 100644 hypertrace/guest/linux-module/Makefile
> >> create mode 100644 hypertrace/guest/linux-module/include/linux/qemu-hypertrace-internal.h
> >> create mode 100644 hypertrace/guest/linux-module/include/linux/qemu-hypertrace.h
> >> create mode 100644 hypertrace/guest/linux-module/qemu-hypertrace.c
>
> > This should be submitted to Linux, the module cannot live in the QEMU
> > tree (we don't carry out-of-tree kernel modules).
>
> I thought it made sense to have it here, the same way we have the user-mode
> guest library. If not, I will split it into a separate repo and point at it from
> the documentation file. Once the rest is merged into QEMU, I can post the kernel
> module repo to the linux list.
Linux doesn't have a stable kernel module API. Out-of-tree modules
bitrot if they are not actively rebased. Getting the module into
linux.git avoids these problems.
The Linux maintainers may give you feedback that requires changes to the
current design, so please send the patch to them now instead of waiting.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-01-16 10:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 20:34 [Qemu-devel] [PATCH v4 0/6] hypertrace: Lightweight guest-to-QEMU trace channel Lluís Vilanova
2016-12-26 20:34 ` [Qemu-devel] [PATCH v4 1/6] hypertrace: Add documentation Lluís Vilanova
2016-12-26 20:34 ` [Qemu-devel] [PATCH v4 2/6] hypertrace: Add tracing event "guest_hypertrace" Lluís Vilanova
2016-12-26 20:34 ` [Qemu-devel] [PATCH v4 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event Lluís Vilanova
2017-01-09 15:44 ` Stefan Hajnoczi
2017-01-16 17:05 ` Lluís Vilanova
2017-01-17 9:46 ` Stefan Hajnoczi
2017-01-17 23:35 ` Lluís Vilanova
2017-01-16 17:10 ` Lluís Vilanova
2017-01-09 16:35 ` Stefan Hajnoczi
2017-01-09 18:20 ` Lluís Vilanova
2017-01-10 14:47 ` Stefan Hajnoczi
2016-12-26 20:34 ` [Qemu-devel] [PATCH v4 4/6] hypertrace: [softmmu] " Lluís Vilanova
2017-01-09 16:12 ` Stefan Hajnoczi
2016-12-26 20:35 ` [Qemu-devel] [PATCH v4 5/6] hypertrace: Add guest-side user-level library Lluís Vilanova
2016-12-26 20:35 ` [Qemu-devel] [PATCH v4 6/6] hypertrace: Add guest-side Linux module Lluís Vilanova
2017-01-09 16:17 ` Stefan Hajnoczi
2017-01-15 2:10 ` Lluís Vilanova
2017-01-16 10:37 ` Stefan Hajnoczi [this message]
2016-12-26 20:47 ` [Qemu-devel] [PATCH v4 0/6] hypertrace: Lightweight guest-to-QEMU trace channel no-reply
2017-01-09 16:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116103700.GA12351@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).