qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 11/11] async: optimize aio_bh_poll
Date: Mon, 16 Jan 2017 13:39:11 +0000	[thread overview]
Message-ID: <20170116133911.21684-12-stefanha@redhat.com> (raw)
In-Reply-To: <20170116133911.21684-1-stefanha@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Avoid entering the slow path of qemu_lockcnt_dec_and_lock if
no bottom half has to be deleted.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 20170112180800.21085-11-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 async.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/async.c b/async.c
index 2305e11..0d218ab 100644
--- a/async.c
+++ b/async.c
@@ -92,6 +92,7 @@ int aio_bh_poll(AioContext *ctx)
 {
     QEMUBH *bh, **bhp, *next;
     int ret;
+    bool deleted = false;
 
     qemu_lockcnt_inc(&ctx->list_lock);
 
@@ -112,9 +113,17 @@ int aio_bh_poll(AioContext *ctx)
             bh->idle = 0;
             aio_bh_call(bh);
         }
+        if (bh->deleted) {
+            deleted = true;
+        }
     }
 
     /* remove deleted bhs */
+    if (!deleted) {
+        qemu_lockcnt_dec(&ctx->list_lock);
+        return ret;
+    }
+
     if (qemu_lockcnt_dec_and_lock(&ctx->list_lock)) {
         bhp = &ctx->first_bh;
         while (*bhp) {
@@ -128,7 +137,6 @@ int aio_bh_poll(AioContext *ctx)
         }
         qemu_lockcnt_unlock(&ctx->list_lock);
     }
-
     return ret;
 }
 
-- 
2.9.3

  parent reply	other threads:[~2017-01-16 13:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 13:39 [Qemu-devel] [PULL 00/11] Block patches Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 01/11] block: get rid of bdrv_io_unplugged_begin/end Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 02/11] aio: rename bh_lock to list_lock Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 03/11] qemu-thread: introduce QemuLockCnt Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 04/11] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 05/11] qemu-thread: optimize QemuLockCnt with futexes on Linux Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 06/11] aio-posix: split aio_dispatch_handlers out of aio_dispatch Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 07/11] aio: tweak walking in dispatch phase Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 08/11] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 09/11] aio-win32: " Stefan Hajnoczi
2017-01-16 13:39 ` [Qemu-devel] [PULL 10/11] aio: document locking Stefan Hajnoczi
2017-01-16 13:39 ` Stefan Hajnoczi [this message]
2017-01-17 13:53 ` [Qemu-devel] [PULL 00/11] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116133911.21684-12-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).