From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1655702] Re: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Date: Mon, 16 Jan 2017 17:59:31 -0000 [thread overview]
Message-ID: <20170116175932.12526.24632.malone@soybean.canonical.com> (raw)
In-Reply-To: 20170111162323.27094.66518.malonedeb@chaenomeles.canonical.com
Thanks for the report -- patch sent to mailing list which deletes the
variable.
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1655702
Title:
qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Status in QEMU:
In Progress
Bug description:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions
next prev parent reply other threads:[~2017-01-16 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:23 [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? dcb
2017-01-16 17:59 ` Peter Maydell [this message]
2017-02-06 16:46 ` [Qemu-devel] [Bug 1655702] " Peter Maydell
2017-04-24 7:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116175932.12526.24632.malone@soybean.canonical.com \
--to=peter.maydell@linaro.org \
--cc=1655702@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).