* [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
@ 2017-01-11 16:23 dcb
2017-01-16 17:59 ` [Qemu-devel] [Bug 1655702] " Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: dcb @ 2017-01-11 16:23 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1655702
Title:
qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Status in QEMU:
New
Bug description:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [Bug 1655702] Re: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
2017-01-11 16:23 [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? dcb
@ 2017-01-16 17:59 ` Peter Maydell
2017-02-06 16:46 ` Peter Maydell
2017-04-24 7:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2017-01-16 17:59 UTC (permalink / raw)
To: qemu-devel
Thanks for the report -- patch sent to mailing list which deletes the
variable.
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1655702
Title:
qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Status in QEMU:
In Progress
Bug description:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [Bug 1655702] Re: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
2017-01-11 16:23 [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? dcb
2017-01-16 17:59 ` [Qemu-devel] [Bug 1655702] " Peter Maydell
@ 2017-02-06 16:46 ` Peter Maydell
2017-04-24 7:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2017-02-06 16:46 UTC (permalink / raw)
To: qemu-devel
Now fixed in git master, commit e62694a078f182.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1655702
Title:
qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Status in QEMU:
Fix Committed
Bug description:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [Bug 1655702] Re: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
2017-01-11 16:23 [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? dcb
2017-01-16 17:59 ` [Qemu-devel] [Bug 1655702] " Peter Maydell
2017-02-06 16:46 ` Peter Maydell
@ 2017-04-24 7:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2017-04-24 7:35 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1655702
Title:
qemu/hw/char/exynos4210_uart.c: possible pointless local variable ?
Status in QEMU:
Fix Released
Bug description:
$ fgrep frame_size qemu/hw/char/exynos4210_uart.c
int speed, parity, data_bits, stop_bits, frame_size;
frame_size = 1; /* start bit */
frame_size++; /* parity bit */
frame_size += data_bits + stop_bits;
$
Suggest either use it or delete it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-24 7:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-11 16:23 [Qemu-devel] [Bug 1655702] [NEW] qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? dcb
2017-01-16 17:59 ` [Qemu-devel] [Bug 1655702] " Peter Maydell
2017-02-06 16:46 ` Peter Maydell
2017-04-24 7:35 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).