From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTBfP-00024Q-JL for qemu-devel@nongnu.org; Mon, 16 Jan 2017 13:06:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTBfM-00037u-FH for qemu-devel@nongnu.org; Mon, 16 Jan 2017 13:06:03 -0500 Received: from indium.canonical.com ([91.189.90.7]:34265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTBfM-00037m-8o for qemu-devel@nongnu.org; Mon, 16 Jan 2017 13:06:00 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1cTBfK-00087d-Js for ; Mon, 16 Jan 2017 18:05:58 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 6B5182E80CE for ; Mon, 16 Jan 2017 18:05:57 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Jan 2017 17:59:31 -0000 From: Peter Maydell Reply-To: Bug 1655702 <1655702@bugs.launchpad.net> Sender: bounces@canonical.com References: <20170111162323.27094.66518.malonedeb@chaenomeles.canonical.com> Message-Id: <20170116175932.12526.24632.malone@soybean.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1655702] Re: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Thanks for the report -- patch sent to mailing list which deletes the variable. ** Changed in: qemu Status: New =3D> In Progress -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1655702 Title: qemu/hw/char/exynos4210_uart.c: possible pointless local variable ? Status in QEMU: In Progress Bug description: $ fgrep frame_size qemu/hw/char/exynos4210_uart.c int speed, parity, data_bits, stop_bits, frame_size; frame_size =3D 1; /* start bit */ frame_size++; /* parity bit */ frame_size +=3D data_bits + stop_bits; $ Suggest either use it or delete it. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1655702/+subscriptions